Skip to content

Commit f2061eb

Browse files
committed
Improve dagster logging when there are missing upstream dependencies
1 parent 10e25c3 commit f2061eb

1 file changed

Lines changed: 7 additions & 8 deletions

File tree

sds_data_manager/orchestration/imap_job.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -219,11 +219,8 @@ def run_job(
219219
dependency_inputs = self.get_dependencies(
220220
session, context, target_start, target_end
221221
)
222-
223-
if not dependency_inputs:
224-
return SkipReason("Dependency inputs were missing.")
225-
226222
except MissingDependenciesError as e:
223+
context.log.info(f"Skipping job: {e}")
227224
return SkipReason(str(e))
228225

229226
context.log.info(
@@ -836,8 +833,10 @@ def get_spice_file_inputs(self, session, target_start, target_end):
836833
)
837834
if not spice_files and self.job_config.spice_inputs:
838835
# If no SPICE files are returned, but there are SPICE inputs, raise failure
839-
raise MissingDependenciesError(f"""Missing SPICE files between
840-
{target_start} and {target_end}""")
836+
raise MissingDependenciesError(
837+
f"Missing SPICE files ({', '.join(self.job_config.spice_types)}) "
838+
f"between {target_start} and {target_end}"
839+
)
841840

842841
return spice_files
843842

@@ -886,8 +885,8 @@ def get_science_files_inputs(self, context, target_start, target_end):
886885
if not science_processing_inputs:
887886
# Return right away if we have zero science files.
888887
raise MissingDependenciesError(
889-
"No science files were discovered. "
890-
"All jobs require at least one science file."
888+
f"No science files were discovered between {target_start} and "
889+
f"{target_end}. All jobs require at least one science file."
891890
)
892891

893892
return science_processing_inputs

0 commit comments

Comments
 (0)