discussion: best practices and resources helpful to increase quality of spoon

[zielint0]

Propose

• List of IntelliJ IDEA code inspections (included in both free and commercial editions)
• List of software quality guidelines
• List of suggested books

[monperrus]

I don't understand. What do you mean?

[zielint0]

Hello Martin
I would like to suggest some workflow, best practices and resources helpful to increase quality of spoon.
I enumerated some things that came to my mind first in issue's description above.
I plan to finish this task (first version) this weekend.

[monperrus]

Thanks for this effort. Before adding a new file in the repo, I propose that we discuss about this very interesting topic in this thread.

[zielint0]

Fixing defects from IDEA code inspection is in progress.
I suggest to remove unused imports.

More suggestions will come in #2105

[surli]

Hi @zielint0

thanks for your interest in Spoon and software quality.

FYI in order to improve Spoon quality we also have a SonarQube dashboard at this URL: there's plenty of bad smells to fix there! -> https://sonarqube.ow2.org/dashboard?id=fr.inria.gforge.spoon%3Aspoon-core

On a related subject, @ashutosh1598 is working on a repair bot to help fixing those bad smells from Sonar: any help would be appreciated on that subject. You can find more about that here: https://github.com/kth-tcs/sonarqube-repair

[zielint0]

Hello Simon
Thank you for this information. It is very valuable. I will check them and try to exploit (or fix bot per se) :-)

[ashutosh1598]

Currently the main problem with the bot is that sniper mode of spoon isn't working properly. Sniper mode is available at refDJPP. The problem is that source positions in spoon are inconsistent. It can't be used on any code that has a type cast. Any help with #2055 will be very beneficial. The closed issue #1953 is also relevant to sniper mode.

[monperrus]

Hi Tomasz, could you see if some of your old WIP or failing PRs can be closed? Thanks!

[zielint0]

@monperrus
I closed some of them.
Partially I fix them or reintroduce their changes in new PRs.

I am going to fix them all and close them.
They are not abandoned! ;-)