Getting extra round parenthesis on some random places in variable assignments

[Vardhamansankar]

Hello @I-Al-Istannen @MartinWitt @algomaster99

I am trying to get the variable details of a String variable used in the java file as same as below,

String sql = "Select distinct t.NETWORK_IP, t.NETWORK_IP1, t.NETWORK_IP2, t.NETWORK_IP3, t.NETWORK_IP4 " +

1. 			 "from (SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 "+

                 " || '.0' network_ip, "+
				 " TO_NUMBER (t1.ipv4digit1) network_ip1, "+
				 " TO_NUMBER (t1.ipv4digit2) network_ip2, "+
				 " TO_NUMBER (t1.ipv4digit3) network_ip3, "+
				 " TO_NUMBER ('0') network_ip4, t1.t2_team_id, "+
				 " t1.system_owner_id, t1.system_owner_team_id "+
				 " FROM ip_info t1 "+

2. 				 " where t1.binary_ip >= '"+binaryIpStart+"' " +

				 " and t1.binary_ip <= '"+binaryIpEnd+"' " +
				 " ORDER BY network_ip1, network_ip2, network_ip3  "+
				 " ) t order by t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4 ";;

And when I used the spoon code to get the variable 'sql' value, I am getting output as

String sql = "Select distinct t.NETWORK_IP, t.NETWORK_IP1, t.NETWORK_IP2, t.NETWORK_IP3, t.NETWORK_IP4 " +

3. 				 "(from (SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 "+

                 " || '.0' network_ip, "+
				 " TO_NUMBER (t1.ipv4digit1) network_ip1, "+
				 " TO_NUMBER (t1.ipv4digit2) network_ip2, "+
				 " TO_NUMBER (t1.ipv4digit3) network_ip3, "+
				 " TO_NUMBER ('0') network_ip4, t1.t2_team_id, "+
				 " t1.system_owner_id, t1.system_owner_team_id "+
				 " FROM ip_info t1 "+

4. 				 " where t1.binary_ip >= '")+binaryIpStart+"' " +

				 " and t1.binary_ip <= '"+binaryIpEnd+"' " +
				 " ORDER BY network_ip1, network_ip2, network_ip3  "+
				 " ) t order by t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4 ";;

In the above-mentioned code, I am getting round parenthesis in the output in ### lines 3 , 4 which is not present in input codes### 1, 2.

Is there any way to overcome or work around this case with spoon? Or is it a bug from spoon? Please guide me.

[I-Al-Istannen]

Can't reproduce. To be fair though, you didn't provide any example code triggering the error :) That makes actually helping you a lot harder.

I tried:

	@Test
	void testStuff() {
		CtClass<?> ctClass = Launcher.parseClass("public class Foo {\n" +
			"    String binaryIpStart = \"start\";\n" +
			"    String binaryIpEnd = \"end\";\n" +
			"    String sql = \"Select distinct t.NETWORK_IP, t.NETWORK_IP1, t.NETWORK_IP2, t.NETWORK_IP3, t.NETWORK_IP4 \" +\n" +
			"        \"from (SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 \" +\n" +
			"        \" || '.0' network_ip, \" +\n" +
			"        \" TO_NUMBER (t1.ipv4digit1) network_ip1, \" +\n" +
			"        \" TO_NUMBER (t1.ipv4digit2) network_ip2, \" +\n" +
			"        \" TO_NUMBER (t1.ipv4digit3) network_ip3, \" +\n" +
			"        \" TO_NUMBER ('0') network_ip4, t1.t2_team_id, \" +\n" +
			"        \" t1.system_owner_id, t1.system_owner_team_id \" +\n" +
			"        \" FROM ip_info t1 \" +\n" +
			"        \" where t1.binary_ip >= '\" + binaryIpStart + \"' \" +\n" +
			"        \" and t1.binary_ip <= '\" + binaryIpEnd + \"' \" +\n" +
			"        \" ORDER BY network_ip1, network_ip2, network_ip3  \" +\n" +
			"        \" ) t order by t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4 \";\n" +
			"}\n");
		CtExpression<?> sql = ctClass.getField("sql").getAssignment();
		StringBuilder result = new StringBuilder();
		sql.accept(new CtScanner() {
			@Override
			public <T> void visitCtLiteral(CtLiteral<T> literal) {
				result.append(literal.getValue());
			}
		});
		System.out.println(result.toString().strip().replaceAll("\\s{2,}", " "));
	}

But that correctly produces

Select distinct t.NETWORK_IP, t.NETWORK_IP1, t.NETWORK_IP2, t.NETWORK_IP3, t.NETWORK_IP4 from (SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 || '.0' network_ip, TO_NUMBER (t1.ipv4digit1) network_ip1, TO_NUMBER (t1.ipv4digit2) network_ip2, TO_NUMBER (t1.ipv4digit3) network_ip3, TO_NUMBER ('0') network_ip4, t1.t2_team_id, t1.system_owner_id, t1.system_owner_team_id FROM ip_info t1 where t1.binary_ip >= '' and t1.binary_ip <= '' ORDER BY network_ip1, network_ip2, network_ip3 ) t order by t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4

which prettifies to

SELECT DISTINCT t.NETWORK_IP,
         t.NETWORK_IP1,
         t.NETWORK_IP2,
         t.NETWORK_IP3,
         t.NETWORK_IP4
FROM 
	(SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 || '.0' network_ip, TO_NUMBER (t1.ipv4digit1) network_ip1, TO_NUMBER (t1.ipv4digit2) network_ip2, TO_NUMBER (t1.ipv4digit3) network_ip3, TO_NUMBER ('0') network_ip4, t1.t2_team_id, t1.system_owner_id, t1.system_owner_team_id
	FROM ip_info t1
	WHERE t1.binary_ip >= ''
	        AND t1.binary_ip <= ''
	ORDER BY  network_ip1, network_ip2, network_ip3 ) t
ORDER BY  t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4

[I-Al-Istannen]

Hey @Vardhamansankar, using my test above this produces

SELECT DISTINCT t.NETWORK_IP,
         t.NETWORK_IP1,
         t.NETWORK_IP2,
         t.NETWORK_IP3,
         t.NETWORK_IP4
FROM 
	(SELECT DISTINCT t1.ipv4digit1 || '.' || t1.ipv4digit2 || '.' || t1.ipv4digit3 || '.0' network_ip, TO_NUMBER (t1.ipv4digit1) network_ip1, TO_NUMBER (t1.ipv4digit2) network_ip2, TO_NUMBER (t1.ipv4digit3) network_ip3, TO_NUMBER ('0') network_ip4, t1.t2_team_id, t1.system_owner_id, t1.system_owner_team_id
	FROM ip_info t1
	WHERE t1.binary_ip >= ''
	        AND t1.binary_ip <= ''
	ORDER BY  network_ip1, network_ip2, network_ip3 ) t
ORDER BY  t.NETWORK_IP1,t.NETWORK_IP2,t.NETWORK_IP3,t.NETWORK_IP4 

which is identical and (as far as I can see) correct.

My full code is:

	@Test
	void testStuff() throws Exception {
		CtClass<?> ctClass = Launcher.parseClass(Files.readString(Path.of("/tmp/test/HibernateIpvNetworkIpDao.java")));
		CtBlock<?> body = ctClass.getMethodsByName("searhNetworkIpRangeByTier1").get(0).getBody();
		CtExpression<?> sql = ((CtLocalVariable) body.getStatement(2)).getAssignment();
		StringBuilder result = new StringBuilder();
		sql.accept(new CtScanner() {
			@Override
			public <T> void visitCtLiteral(CtLiteral<T> literal) {
				result.append(literal.getValue());
			}
		});
		System.out.println(result.toString().strip().replaceAll("\\s{2,}", " "));
	}

It would be helpful if you could cut down your processing code (i.e. what my Test above is) to a minimal failing example on your part. The problem sounds quite weird and I am unable to reproduce it.

[Vardhamansankar]

We are having this issue in our code @I-Al-Istannen , is there any other way to work around it, please suggest.

[I-Al-Istannen]

@Vardhamansankar
Please read my previous comment again. I can not reproduce the issue and therefore can not suggest a fix — as far as I can see nothing is broken.

I have provided an example of what I tried to reproduce the issue above, but my example works. If you provide a failing self contained example — as requested by me last month — I can have another look at it. Currently I just did not get enough information from you to provide a useful answer.