Skip to content

Commit 64a0502

Browse files
committed
fix: mcda Goal value Q=0
1 parent 95cc7ce commit 64a0502

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

src/sum_impact_assessment/services/mcda_analysis_job.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def build_goals(kpi_impact_results: list, alternatives: list[Alternative], goal_
171171
name=group_name,
172172
weight=weight,
173173
direction="max", # Higher coefficient = better impact
174-
Q=min_value, # default to min value (disabled effect)
174+
Q=0, # default to min value (disabled effect)
175175
S=0, # default to 0 (not used here)
176176
P=max_value - min_value, # max - min value
177177
F='t3' # V-shape for continuous data

tests/test_services/test_mcda_analysis_job.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def test_builds_goals_with_perspective_weights(self):
301301
assert len(result) == 2
302302
assert result[0].name == "Sustainability"
303303
assert result[0].weight == 0.6
304-
assert result[0].Q == 0.5 # min value
304+
assert result[0].Q == 0 # min value, changed to 0 after MCDA review
305305
# max - min (0.8 - 0.5), using approximate comparison
306306
assert abs(result[0].P - 0.3) < 0.001
307307
assert result[1].name == "Safety"
@@ -384,7 +384,7 @@ def test_goal_attributes_are_correct(self):
384384
goal = result[0]
385385
assert goal.name == "Sustainability"
386386
assert goal.direction == "max"
387-
assert goal.Q == 0.2
387+
assert goal.Q == 0
388388
assert goal.S == 0
389389
assert goal.P == 0.7 # 0.9 - 0.2
390390
assert goal.F == 't3'

0 commit comments

Comments
 (0)