Fix bug that prevented using invalid comb names to mark disconnected setups

Author: mpizzocaro

src/super_auto_comb/cli.py

@@ -199,7 +199,7 @@ def main(args):
             # 	for x in loyb[loyb['datetime']>59900].iloc:
             #  ...:     print(x['cirt'])
             for s in do_setup.iloc:
-                if s["valid"] is False:
+                if s["valid"] == False:  # noqa: E712 # the valid column store np.bool_ for whatever reason
                     continue
 
                 this_start = max(start, s["datetime"])
@@ -346,7 +346,7 @@ def main(args):
 
         # LOOP 4b: tracked changes
         for s in do_out_setup.iloc:
-            if s["valid"] is False:
+            if s["valid"] == False:  # noqa: E712 # the valid column store np.bool_ for whatever reason
                 continue
 
             this_start = max(start, s["datetime"])

tests/samples/LoYb_with_invalid.dat

@@ -0,0 +1,3 @@
+#datetime        	comb	physical	nominal                	kscale	foffset	N	fbeat_sign	f0_scale	counter1	flo1	min1	max1	counter2	flo2	min2	max2	threshold
+2022-03-21T00:00:00	disconnected
+2022-03-21T00:30:00	comb2	cavity4	'518_295_836_590_863.63'	2	67_059_566.	1_036_592	-1	1	11	-154.3e6	58.5e6	59.5e6	12	35.7e6	58.7e6	59.7e6	0.2

tests/test_cli.py

@@ -81,3 +81,20 @@ def test_main_auto():
     rocit_data = rl.load_link_from_dir("./tests/Outputs/2022-03/INRIM_HM-INRIM_LoYb")
     assert len(rocit_data.t) == 3600
     assert rocit_data.oscA.name == "INRIM_LoYb"
+
+
+def test_main_with_invalid():
+    # delete previous results
+    try:
+        shutil.rmtree("./tests/Outputs/")
+    except FileNotFoundError:
+        pass
+    args = parse_args(
+        "--do LoYb_with_invalid --start 59658 --stop 59660 --dir ./tests/Outputs --fig-dir ./tests/Outputs/Figures --comb-dir ./tests/samples --setup-dir ./tests/samples --track-cirt".split(
+            " "
+        )
+    )
+    main(args)
+    rocit_data = rl.load_link_from_dir("./tests/Outputs/INRIM_HM-INRIM_LoYb_with_invalid")
+    assert len(rocit_data.t) == 1801
+    assert rocit_data.oscA.name == "INRIM_LoYb_with_invalid"