Resolve bug in Node.removeChild

removeChild treated `children` as a List of nodes, rather than a
map of String,Node (nodeNames as the String). This meant trying
to remove the Node from the list would silently fail every call.

Author: butlermatt

CHANGELOG.md

@@ -1,5 +1,6 @@
 # ChangeLog
 
+* v1.0.6 - Fix a logic error in removeChild method of Nodes.
 * v1.0.5 - Ensure that QOS downgrades are propagated.
 * v1.0.4+1 - Map logger names to match DSA log levels.
 * v1.0.4 - Forward any errors generated by a `list` request to the requester.

lib/src/common/node.dart

@@ -73,10 +73,15 @@ class Node {
   /// [input] can be either an instance of [Node] or a [String].
   String removeChild(dynamic input) {
     if (input is String) {
-      children.remove(getChild(input));
+      children.remove(input);
       return input;
     } else if (input is Node) {
-      children.remove(input);
+      for (var nodeName in children.keys.toList()) {
+        if ((input as Node) == children[nodeName]) {
+          children.remove(nodeName);
+          return nodeName;
+        }
+      }
     } else {
       throw new Exception("Invalid Input");
     }

pubspec.yaml

@@ -1,5 +1,5 @@
 name: dslink
-version: 1.0.5
+version: 1.0.6
 description: "DSA IoT Platform - DSLink SDK for Dart"
 homepage: "http://iot-dsa.org"
 documentation: "https://iot-dsa.github.io/docs/sdks/dart/"