Skip to content

Commit 08b9c86

Browse files
authored
Merge pull request #12358 from janvanmansum/enable-multipart-upload
Enable S3 multipart upload (in non-direct upload)
2 parents 7904e99 + 8774c43 commit 08b9c86

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed a defect that caused upload of files larger than 1G to fail silently for S3 storage, unless direct upload was used.

src/main/java/edu/harvard/iq/dataverse/dataaccess/S3AccessIO.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,6 +1208,9 @@ private static S3AsyncClient getClient(String driverId) {
12081208
// Create a builder for the S3AsyncClient
12091209
S3AsyncClientBuilder s3CB = S3AsyncClient.builder().requestChecksumCalculation(RequestChecksumCalculation.WHEN_REQUIRED);
12101210

1211+
// Always enable multipart upload. It is only used when necessary
1212+
s3CB.multipartEnabled(true);
1213+
12111214
// Create a custom HTTP client with the desired pool size
12121215
Integer poolSize = Integer.getInteger("dataverse.files." + driverId + ".connection-pool-size", 256);
12131216
Builder httpClientBuilder = NettyNioAsyncHttpClient.builder().maxConcurrency(poolSize);

0 commit comments

Comments
 (0)