Users sometimes see "Guestbook Entry At Access Request" guestbooks when downloading public files

[jggautier]

What steps does it take to reproduce the issue?

• When does this issue occur?
  When trying to download a public or unrestricted file in a dataset that has a guestbook whose mode is "Guestbook Entry At Access Request".

  For example, the dataset at https://doi.org/10.7910/DVN/25833 has such a guestbook applied to it. When a user tries to download a public file in that dataset, they see the guestbook. Also see a dataset on Demo Dataverse.

• Which pages does it occurs on?
  On the dataset page. It may not happen while on the public file's page because of the bug reported at #11800

• What happens?
  The user sees the guestbook

• To whom does it occur (all users, curators, superusers)?
  All users

• What did you expect to happen?
  The user does not see the guestbook, whose mode is "Guestbook Entry At Access Request", when they try to download a public file.

  In the "Configure When a Dataset Guestbook Appears (If Enabled)" section of the Native API guide, we write that when a guestbook's mode is "Guestbook Entry At Access Request," "users may instead be asked to fill out a Guestbook only when they request access to restricted files" in datasets where a guestbook has been applied. I emphasized the "instead" and "only" because they're what make that sentence mean that users should not see such guestbooks when they try to download public files.

  For example, see the dataset at https://doi.org/10.7910/DVN/0NP78B, whose applied guestbook has the mode "Guestbook Entry At Access Request". When a user tries to download the public file in that dataset, they don't see the guestbook.

Which version of Dataverse are you using?
v6.7.1

Any related open or closed issues to this bug report?
#11800

[qqmyers]

I suspect this is the second part of #11800 - it was reported there that the GB appears at download for restricted files at download time - I suspect they erroneously appear at download all the time (only if terms also get shown I think). If so, #11808 should be a fix.

Also, FWIW: GB-at-request/download can be set via API for individual datasets - guessing that's not the issue here, but datasets don't have to inherit the setting from their parent collection.

[jggautier]

Also, FWIW: GB-at-request/download can be set via API for individual datasets - guessing that's not the issue here, but datasets don't have to inherit the setting from their parent collection.

Thanks, yeah, there's an API endpoint described at https://guides.dataverse.org/en/6.7.1/api/native-api.html#configure-when-a-dataset-guestbook-appears-if-enabled I've been using during testing to verify the mode of the guestbook being used by a dataset, just in case it wasn't the same as the guestbook mode of the collection it's in.

I rewrote this issue's first comment to focus on the mode of the guestbook and not on the collection's Guestbook Mode, which like you wrote might not matter if someone used the super-user API to change the mode applied a given dataset.

[jggautier]

@qqmyers mind if I add in #11808 that this issue will also be closed by your PR?