-
Notifications
You must be signed in to change notification settings - Fork 530
6.9 release notes #12041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
6.9 release notes #12041
Conversation
poikilotherm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a couple of 🐛
Also: please please very much please use one sentence per line. It makes typing (and reading) suggestions so much easier. Thanks.
|
|
||
| Replace the brand new `payara/glassfish/domains/domain1` with your old, preserved domain1: | ||
|
|
||
| ```shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These commands make not a lot of sense... It's not well aligned with what was described above and there's at least a typo in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@poikilotherm
Could you clarify, which parts do not make sense and which part is a typo?
After staring at it, somewhat briefly, these really look like the steps we always recommend for an upgrade that allows for re-using the domain from under the version of Payara previously used. With both version numbers seemingly updated correctly.
I may be missing something, obviously.
Moving "only" closer to "collections" for clarity
Removed information about a planned new script in the external vocabulary mechanism' repo that isn't yet ready.
Co-authored-by: Oliver Bertuch <[email protected]>
Co-authored-by: landreev <[email protected]>
|
@poikilotherm thanks for the detailed review and all the suggestions. I implemented the vast majority of them but left a couple unresolved. Please see the replies I left.
I need more space than I have here to unpack this so I created a topic in Zulip about it: https://dataverse.zulipchat.com/#narrow/channel/446770-docs/topic/one.20sentence.20per.20line/near/563628045 @landreev thanks for your suggestions as well. I incorporated them. @jggautier @qqmyers thanks for making fixes. From my perspective, we can probably merge this PR at this point. I think it's the only thing holding us back from a release. Plus, we can always fix it in post. (We can edit the live release notes after release, I mean.) Let's talk about it more at standup on Monday. Thanks, all! ❤️ |
Most changes were implemented. We don't want the merge button to be blocked. Oliver and I plan to discuss other proposed changes tomorrow.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
Here's a preview: https://github.com/IQSS/dataverse/blob/11879-6.9-release-notes/doc/release-notes/6.9-release-notes.md
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: