Skip to content

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Dec 11, 2025

What this PR does / why we need it:

Which issue(s) this PR closes:

Special notes for your reviewer:

Here's a preview: https://github.com/IQSS/dataverse/blob/11879-6.9-release-notes/doc/release-notes/6.9-release-notes.md

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@github-actions github-actions bot added FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) Release Issue is related to making a software release (e.g., Dataverse) Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) labels Dec 11, 2025
@pdurbin pdurbin added this to the 6.9 milestone Dec 11, 2025
@landreev landreev moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Dec 11, 2025
@landreev landreev self-assigned this Dec 11, 2025
Copy link
Contributor

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a couple of 🐛

Also: please please very much please use one sentence per line. It makes typing (and reading) suggestions so much easier. Thanks.


Replace the brand new `payara/glassfish/domains/domain1` with your old, preserved domain1:

```shell
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commands make not a lot of sense... It's not well aligned with what was described above and there's at least a typo in here.

Copy link
Contributor

@landreev landreev Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poikilotherm
Could you clarify, which parts do not make sense and which part is a typo?
After staring at it, somewhat briefly, these really look like the steps we always recommend for an upgrade that allows for re-using the domain from under the version of Payara previously used. With both version numbers seemingly updated correctly.
I may be missing something, obviously.

@jggautier jggautier requested review from jggautier and removed request for jggautier December 12, 2025 16:30
@pdurbin
Copy link
Member Author

pdurbin commented Dec 13, 2025

@poikilotherm thanks for the detailed review and all the suggestions. I implemented the vast majority of them but left a couple unresolved. Please see the replies I left.

Also: please please very much please use one sentence per line. It makes typing (and reading) suggestions so much easier. Thanks.

I need more space than I have here to unpack this so I created a topic in Zulip about it: https://dataverse.zulipchat.com/#narrow/channel/446770-docs/topic/one.20sentence.20per.20line/near/563628045

@landreev thanks for your suggestions as well. I incorporated them.

@jggautier @qqmyers thanks for making fixes.

From my perspective, we can probably merge this PR at this point. I think it's the only thing holding us back from a release. Plus, we can always fix it in post. (We can edit the live release notes after release, I mean.) Let's talk about it more at standup on Monday.

Thanks, all! ❤️

@coveralls
Copy link

Coverage Status

coverage: 24.233%. remained the same
when pulling f4292e6 on 11879-6.9-release-notes
into fd75558 on develop.

@pdurbin pdurbin dismissed poikilotherm’s stale review December 15, 2025 19:47

Most changes were implemented. We don't want the merge button to be blocked. Oliver and I plan to discuss other proposed changes tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 12 FY26 Sprint 12 (2025-12-03 - 2025-12-17) Release Issue is related to making a software release (e.g., Dataverse) Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)

Projects

Status: In Review 🔎

Development

Successfully merging this pull request may close these issues.

Release 6.9: Create release notes

7 participants