MyData API: Return empty result set instead or error#12256
Open
stevenwinship wants to merge 11 commits intodevelopfrom
Open
MyData API: Return empty result set instead or error#12256stevenwinship wants to merge 11 commits intodevelopfrom
stevenwinship wants to merge 11 commits intodevelopfrom
Conversation
github-actions
Bot
added
GREI Re-arch
stevenwinship
changed the title
stevenwinship
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
stevenwinship
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
This comment has been minimized.
This comment has been minimized.
|
Coverage is 24.949% — 11447-mydata-retrieve-empty-result-set into develop. No base build found for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11447-mydata-retrieve-empty-result-set
branch
from
8531689 to
20b796d
Compare
This comment has been minimized.
This comment has been minimized.
stevenwinship
force-pushed
the
11447-mydata-retrieve-empty-result-set
branch
from
20b796d to
0a8a55a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
@stevenwinship I'm getting an error in the DataRetrieverApiIT. On line 103 it's finding 0 instead of 1. Also the branch is out of date with dev. |
Contributor
Author
|
I'm not seeing the error. There is a 4 second sleep that might be too short? I updated the branch and will run it again |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: SPA needs empty result set instead of error when no results are found
Which issue(s) this PR closes:#11447
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: changelog as this is a breaking change