Update GitHub Action workflows and pre-commit config

Author: jochenklar

.github/workflows/release.yml

@@ -1,55 +1,62 @@
-name: release
-
-on: push
+name: Release 🚀
+
+on:
+  push:
+    branches:
+      - main
+    tags:
+      - "*"
+  pull_request:
+    branches:
+      - main
 
 jobs:
   build:
-    name: Build distribution 📦
+    name: Build distribution 👷
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v6
+    - name: Checkout repo 🛎️
+      uses: actions/checkout@v6
       with:
         persist-credentials: false
 
-    - name: Set up Python
+    - name: Set up Python 🐍
       uses: actions/setup-python@v6
       with:
         python-version: "3.x"
 
-    - name: Install build
+    - name: Install build 🧱
       run: python3 -m pip install build --user
 
-    - name: Build a binary wheel and a source tarball
+    - name: Build a binary wheel and a source tarball 🛠️
       run: python3 -m build
 
-    - name: Store the distribution packages
+    - name: Store the distribution packages 📤
       uses: actions/upload-artifact@v5
       with:
         name: python-package-distributions
         path: dist/
 
   publish:
-    name: Publish Python 🐍 distribution 📦 to PyPI
+    name: Publish distribution to PyPI 📦
     if: startsWith(github.ref, 'refs/tags/')
-
-    needs:
-    - build
-
+    needs: build
     runs-on: ubuntu-latest
+
     environment:
       name: pypi
       url: https://pypi.org/p/django-datacite
 
     permissions:
       id-token: write
 
-   steps:
-    - name: Download all the dists
+    steps:
+    - name: Download the distribution packages 📥
       uses: actions/download-artifact@v6
       with:
         name: python-package-distributions
         path: dist/
 
-    - name: Publish distribution 📦 to PyPI
+    - name: Publish to PyPI 🚀
       uses: pypa/gh-action-pypi-publish@release/v1

.github/workflows/pytest.yml .github/workflows/test.yml.github/workflows/pytest.yml renamed to .github/workflows/test.yml

@@ -1,14 +1,23 @@
-name: pytest
+name: Test 🧪
 
-on: push
+on:
+  push:
+    branches:
+      - main
+    tags:
+      - "*"
+  pull_request:
+    branches:
+      - main
 
 jobs:
   pytest:
-    runs-on: ubuntu-22.04
+    name: Run pytest 🧪
+    runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        python-version: ['3.8', '3.12']
+        python-version: ['3.8', '3.14']
 
     services:
       postgres:
@@ -24,32 +33,33 @@ jobs:
           --health-retries 5
 
     steps:
-    - uses: actions/checkout@v6
+    - name: Checkout repo 🛎️
+      uses: actions/checkout@v6
       with:
         persist-credentials: false
 
-    - name: Set up Python ${{ matrix.python-version }}
+    - name: Set up Python ${{ matrix.python-version }} 🐍
       uses: actions/setup-python@v6
       with:
         python-version: ${{ matrix.python-version }}
 
-    - name: Install package
+    - name: Install package 📦
       run: |
         python3 -m pip install --upgrade pip setuptools
         python3 -m pip install psycopg2-binary
         python3 -m pip install -e .
         python3 -m pip install -e .[pytest]
 
-    - name: Setup environment file
+    - name: Setup environment file 🔐
       run: |
         echo "SECRET_KEY=thisisnotaverysecretkey" >> $GITHUB_ENV
         echo "DATABASE=postgresql://postgres:postgres_password@localhost/django_datacite" >> $GITHUB_ENV
 
-    - name: Run pytest
+    - name: Run pytest 🧪
       run: |
         pytest --cov
 
-    - name: Run coveralls
+    - name: Run coveralls 📊
       uses: coverallsapp/github-action@v2
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
@@ -59,10 +69,11 @@ jobs:
   coveralls:
     needs: pytest
     runs-on: ubuntu-latest
+
     steps:
-    - name: Run coveralls finish
+    - name: Run coveralls finish 🏁
       uses: coverallsapp/github-action@v2
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
         parallel-finished: true
-        carryforward: "3.7,3.11"
+        carryforward: "3.7,3.14"

.pre-commit-config.yaml

@@ -5,14 +5,14 @@ repos:
     hooks:
       - id: check-hooks-apply
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.4.0
+    rev: v6.0.0
     hooks:
       - id: check-ast
       - id: end-of-file-fixer
       - id: trailing-whitespace
       - id: debug-statements
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.284
+    rev: v0.14.14
     hooks:
       - id: ruff
         args: [--fix, --exit-non-zero-on-fix]

django_datacite/imports.py

@@ -434,7 +434,7 @@ def import_name(name_node):
     # update name identifiers
     for name_identifier_instance in name_identifier_instances:
         try:
-            name_identifier_instance.name
+            name_identifier_instance.name  # noqa: B018
         except Name.DoesNotExist:
             name_identifier_instance.name = name_instance
             name_identifier_instance.save()
@@ -496,7 +496,7 @@ def import_geo_location(geo_location_node):
     if geo_location_point and \
             geo_location_point.get('pointLongitude') is not None and \
             geo_location_point.get('pointLatitude') is not None:
-        geo_location_point_instance, created = GeoLocationPoint.objects.update_or_create(
+        _, created = GeoLocationPoint.objects.update_or_create(
             geo_location=geo_location_instance,
             defaults={
                 'point_longitude': geo_location_point.get('pointLongitude'),
@@ -510,7 +510,7 @@ def import_geo_location(geo_location_node):
             geo_location_bbox.get('eastBoundLongitude') is not None and \
             geo_location_bbox.get('southBoundLatitude') is not None and \
             geo_location_bbox.get('northBoundLatitude') is not None:
-        geo_location_bbox_instance, created = GeoLocationBox.objects.update_or_create(
+        _, created = GeoLocationBox.objects.update_or_create(
             geo_location=geo_location_instance,
             defaults={
                 'west_bound_longitude': geo_location_bbox.get('westBoundLongitude'),
@@ -528,7 +528,7 @@ def import_geo_location(geo_location_node):
                 [point.get('pointLongitude'), point.get('pointLatitude')]
                 for point in polygon_points
             ]
-            geo_location_polygon_instance, created = GeoLocationPolygon.objects.update_or_create(
+            _, created = GeoLocationPolygon.objects.update_or_create(
                 geo_location=geo_location_instance,
                 polygon_points=polygon_points_json,
                 in_point_longitude=geo_location_polygon.get('inPolygonPoint', {}).get('pointLongitude'),