Skip to content

Commit 3336927

Browse files
authored
Remove use of async_trait (#304)
## Summary of changes `async_trait` is no longer required for our direct use cases. ## Instruction for review/testing - Code review
1 parent 333e0b4 commit 3336927

File tree

5 files changed

+1
-8
lines changed

5 files changed

+1
-8
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ edition = "2021"
2222
[workspace.dependencies]
2323
anyhow = "1.0"
2424
assert_approx_eq = "1.1.0"
25-
async-trait = "0.1.83"
2625
chrono = { version = "0.4.39", features = ["serde"] }
2726
clap = { version = "4.5", features = ["derive", "env"] }
2827
crossterm = "0.26.1"

trace-archiver-tdengine/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ edition.workspace = true
66

77
[dependencies]
88
anyhow.workspace = true
9-
async-trait.workspace = true
109
chrono.workspace = true
1110
clap.workspace = true
1211
itertools.workspace = true

trace-archiver-tdengine/src/tdengine/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@ pub mod framedata;
44
mod views;
55
pub mod wrapper;
66

7-
use async_trait::async_trait;
87
use error::{StatementErrorCode, TDEngineError, TraceMessageErrorCode};
98
use supermusr_streaming_types::dat2_digitizer_analog_trace_v2_generated::DigitizerAnalogTraceMessage;
109

11-
#[async_trait]
1210
pub(crate) trait TimeSeriesEngine {
1311
async fn process_message(&mut self, msg: &DigitizerAnalogTraceMessage) -> anyhow::Result<()>;
1412
async fn post_message(&mut self) -> anyhow::Result<usize>;

trace-archiver-tdengine/src/tdengine/wrapper.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use super::{
44
views::{create_column_views, create_frame_column_views},
55
StatementErrorCode, TDEngineError, TimeSeriesEngine, TraceMessageErrorCode,
66
};
7-
use async_trait::async_trait;
87
use supermusr_streaming_types::dat2_digitizer_analog_trace_v2_generated::DigitizerAnalogTraceMessage;
98
use taos::{AsyncBindable, AsyncQueryable, AsyncTBuilder, Stmt, Taos, TaosBuilder, Value};
109
use tracing::debug;
@@ -130,7 +129,6 @@ impl TDEngine {
130129
}
131130
}
132131

133-
#[async_trait]
134132
impl TimeSeriesEngine for TDEngine {
135133
/// Takes a reference to a ``DigitizerAnalogTraceMessage`` instance and extracts the relevant data from it.
136134
/// The user should then call ``post_message`` to send the data to the tdengine server.
@@ -141,7 +139,7 @@ impl TimeSeriesEngine for TDEngine {
141139
/// An emtpy result or an error arrising a malformed ``DigitizerAnalogTraceMessage`` parameter.
142140
async fn process_message(
143141
&mut self,
144-
message: &DigitizerAnalogTraceMessage,
142+
message: &DigitizerAnalogTraceMessage<'_>,
145143
) -> anyhow::Result<()> {
146144
// Obtain the channel data, and error check
147145
self.error.test_metadata(message);

0 commit comments

Comments
 (0)