VersionCheck: use additional-exclude-paths for NDTensors#1757
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
=======================================
Coverage 81.02% 81.02%
=======================================
Files 80 80
Lines 5074 5074
=======================================
Hits 4111 4111
Misses 963 963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace the explicit `exclude-paths` override with `additional-exclude-paths: NDTensors`. The previous list re-declared the reusable workflow's defaults (`.github`, `.gitignore`, `.pre-commit-config.yaml`) to keep `NDTensors` alongside them, which then silently drifted as defaults evolved (e.g. the recent `jenkins` addition wasn't picked up). The new input extends the defaults instead of replacing them. Requires ITensorActions v2 to include the `additional-exclude-paths` input (added in ITensor/ITensorActions#122). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mtfishman
force-pushed
the
mf/additional-exclude-paths
branch
from
babdbbc to
8287400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude-pathsoverride withadditional-exclude-paths: NDTensors. The previous list re-declared the reusable workflow's defaults (.github,.gitignore,.pre-commit-config.yaml) to keepNDTensorsalongside them, which silently drifted as defaults evolved — the recentjenkinsaddition wasn't picked up, which is why VersionCheck has been failing on PRs that touch onlyjenkins/(e.g. [jenkins] updates for migration to new k8s-based system #1754).additional-exclude-pathsinput added in VersionCheck: add additional-exclude-paths input ITensorActions#122 (released asv2.4.0).