Unsupported member access: Id on Convert after upgrade to 1.15.11 from 1.14.16 (PostgreSql repository)

[bjornharrtell]

Stack trace:

System.Exception:
at FoxIDs.Infrastructure.Hosting.RouteBindingMiddleware+d__3.MoveNext (FoxIDs.Shared, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs.Shared/Infrastructure/Hosting/RouteBindingMiddleware.cs:52)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at FoxIDs.Infrastructure.Hosting.FoxIDsProxyHeadersMiddleware+d__1.MoveNext (FoxIDs, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs/Infrastructure/Hosting/FoxIDsProxyHeadersMiddleware.cs:37)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddlewareImpl+<g__Awaited|10_0>d.MoveNext (Microsoft.AspNetCore.Diagnostics, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
Inner exception FoxIDs.Logic.EndpointException handled at FoxIDs.Infrastructure.Hosting.RouteBindingMiddleware+d__3.MoveNext:
at FoxIDs.Controllers.LoginController+d__28.MoveNext (FoxIDs, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs/Controllers/LoginController.cs:673)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at FoxIDs.Controllers.LoginController+<Login>d__15.MoveNext (FoxIDs, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs/Controllers/LoginController.cs:122) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+TaskOfIActionResultExecutor+<Execute>d__0.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.ValueTaskAwaiter1.GetResult (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<g__Awaited|12_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<g__Awaited|10_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker+<g__Awaited|13_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Awaited|25_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Awaited|20_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Awaited|17_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker+<g__Awaited|17_0>d.MoveNext (Microsoft.AspNetCore.Mvc.Core, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware+d__11.MoveNext (Microsoft.AspNetCore.Authorization.Policy, Version=9.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at FoxIDs.Infrastructure.Hosting.RouteBindingMiddleware+d__3.MoveNext (FoxIDs.Shared, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs.Shared/Infrastructure/Hosting/RouteBindingMiddleware.cs:47)
Inner exception System.NotSupportedException handled at FoxIDs.Controllers.LoginController+d__28.MoveNext:
at Wololo.PgKeyValueDB.SqlExpressionVisitor.VisitMember (PgKeyValueDB, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null)
at Wololo.PgKeyValueDB.SqlExpressionVisitor.VisitBinary (PgKeyValueDB, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null)
at Wololo.PgKeyValueDB.SqlExpressionVisitor.VisitBinary (PgKeyValueDB, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null)
at System.Linq.Expressions.ExpressionVisitor.VisitLambda (System.Linq.Expressions, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a)
at Wololo.PgKeyValueDB.PgKeyValueDB.GetListAsync (PgKeyValueDB, Version=1.0.1.0, Culture=neutral, PublicKeyToken=null)
at FoxIDs.Repository.PgTenantDataRepository+d__41.MoveNext (FoxIDs.Shared, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null) at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e) at System.Runtime.CompilerServices.ValueTaskAwaiter1.GetResult (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at FoxIDs.Logic.AccountLogic+d__3.MoveNext (FoxIDs, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs/Logic/Tracks/AccountLogic.cs:33)
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult (System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e)
at FoxIDs.Controllers.LoginController+d__28.MoveNext (FoxIDs, Version=1.15.11.0, Culture=neutral, PublicKeyToken=null: /src/src/FoxIDs/Controllers/LoginController.cs:636)

[Revsgaard]

AdditionalIds is a list of IDs a object can have. In the first place only used on users. From version 1.15.* a user can have three different user identifiers; email, username and phone number. The AdditionalIds is used to add unique IDs for them all and add a constrained.

DataElement with AdditionalIds https://github.com/ITfoxtec/FoxIDs/blob/main/src/FoxIDs.Shared/Models/Base/DataElement.cs.

The problem is in https://github.com/ITfoxtec/FoxIDs/blob/main/src/FoxIDs.Shared/Repository/PostgreSql/PgTenantDataRepository.cs#L62

`Expression<Func<T, bool>> whereQuery = q => q.Id == id || q.AdditionalIds.Contains(id);`

Neither the ID og the AdditionalIds query are working.

It could also be written like this:

`Expression<Func<T, bool>> whereQuery = q => q.Id == id || q.AdditionalIds.Where(ai => ai.Id == id).Any();`

The Where and Any notation is also use another place in the code.

Maybe it is better if the PgKeyValueDB libery support AdditionalIds natively?

There is also missing a unique ID constrained. Is that something you can fix?

I'm sorry for this problem, I should have focused more on it.

[bjornharrtell]

@Revsgaard yes, ideally should have some integration tests for the provider(s). I've started an early unfinished draft that does help me reproduce this problem locally.

Still not sure what "Unsupported member access: Id on Convert" really means and how to reproduce it in upstream with a more simple test... but I'll be happy to continue looking into it.

I assume you closed this by mistake?

[Revsgaard]

Yes, open again : )

The q => q.Id == id throws the error "Unsupported member access: Id on Convert".

[bjornharrtell]

Ok but that confuses me... I would have understood if the problem is with the List property and Contains on it.

I also do not quite understand your requirements for the unique check.

[bjornharrtell]

With bjornharrtell/PgKeyValueDB#15 and bjornharrtell/PgKeyValueDB#16 it seems results are promising but I do get one test failure which I do not understand.. perhaps just something I did wrong in the quick and dirty port of the unit to integration test:

CreateUserCheckPasswordRisk_ThrowPasswordRiskException(email: "a1@test.com", password: "!QAZ2wsx") (9s 601ms): Error Message: Assert.Throws() Failure: No exception was thrown

Besides this I still think I need to understand your unique check requirement.

[Revsgaard]

The password "!QAZ2wsx" need to be in the database as a risk/leaked password (represented as a hash) before it fails.

Up until now a user only had an email user identifier which was connected to the objects ID. The ID has a unique constrained.
From version 1.15.* a user can have three different user identifiers; email, username and phone number. Which results in three IDs at the same time and no one other in the environment/track is a allowed to have any of the IDs. To achieve this all three IDs is added to the new AdditionalIds list which then need a unique constrained.

[bjornharrtell]

@Revsgaard ok I'm not sure I can/want to scope in unique constraint in PgKeyValueDB. I guess a repository specific logic that does a check before adding/updating to a new one should suffice?

[Revsgaard]

https://github.com/ITfoxtec/FoxIDs/releases/tag/1.15.14

[Revsgaard]

The AdditionalIdExistAsync should check if additional IDs exists, but it fails because the q.AdditionalIds.Contains(idOrAdditionalId) do not find anything. @bjornharrtell, please have a look.

Code link:
https://github.com/ITfoxtec/FoxIDs/blob/1.16.x-development/src/FoxIDs.Shared/Repository/PostgreSql/PgTenantDataRepository.cs#L213

[bjornharrtell]

Hmm that is strange indeed, I have this upstream test proving that contains filtering works - https://github.com/bjornharrtell/PgKeyValueDB/blob/main/test/PgKeyValueDB.Tests/PgKeyValueDBTest.cs#L523. But I will try to find an explanation...