Skip to content

Commit 662544c

Browse files
committed
Move post binding validation from the UnbindInternal method to the Read method.
1 parent 0b96c1f commit 662544c

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

src/ITfoxtec.Identity.Saml2.Mvc/ITfoxtec.Identity.Saml2.Mvc.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@
1414
<PackageTags>SAML SAML 2.0 SAML2.0 SAML2 SAML 2 SAML-P SAMLP SSO Identity Provider (IdP) and Relying Party (RP) Authentication Metadata OIOSAML NemLog-in ASP.NET MVC</PackageTags>
1515
<NeutralLanguage>en-US</NeutralLanguage>
1616
<PackageIconUrl>https://itfoxtec.com/favicon.ico</PackageIconUrl>
17-
<AssemblyVersion>4.5.0.0</AssemblyVersion>
18-
<FileVersion>4.5.0.0</FileVersion>
17+
<AssemblyVersion>4.5.1.0</AssemblyVersion>
18+
<FileVersion>4.5.1.0</FileVersion>
1919
<Copyright>Copyright © 2021</Copyright>
20-
<Version>4.5.0</Version>
20+
<Version>4.5.1</Version>
2121
<SignAssembly>true</SignAssembly>
2222
<AssemblyOriginatorKeyFile>ITfoxtec.SAML2.snk</AssemblyOriginatorKeyFile>
2323
<DelaySign>false</DelaySign>

src/ITfoxtec.Identity.Saml2.MvcCore/ITfoxtec.Identity.Saml2.MvcCore.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
<PackageTags>SAML SAML 2.0 SAML2.0 SAML2 SAML 2 SAML-P SAMLP SSO Identity Provider (IdP) Relying Party (RP) Authentication Metadata OIOSAML NemLog-in ASP.NET MVC Core</PackageTags>
1717
<NeutralLanguage>en-US</NeutralLanguage>
1818
<PackageIconUrl>https://itfoxtec.com/favicon.ico</PackageIconUrl>
19-
<AssemblyVersion>4.5.0.0</AssemblyVersion>
20-
<FileVersion>4.5.0.0</FileVersion>
19+
<AssemblyVersion>4.5.1.0</AssemblyVersion>
20+
<FileVersion>4.5.1.0</FileVersion>
2121
<Copyright>Copyright © 2021</Copyright>
22-
<Version>4.5.0</Version>
22+
<Version>4.5.1</Version>
2323
<SignAssembly>true</SignAssembly>
2424
<AssemblyOriginatorKeyFile>ITfoxtec.SAML2.snk</AssemblyOriginatorKeyFile>
2525
<DelaySign>false</DelaySign>

src/ITfoxtec.Identity.Saml2/Bindings/Saml2PostBinding.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,17 +103,17 @@ protected override Saml2Request UnbindInternal(HttpRequest request, Saml2Request
103103
{
104104
UnbindInternal(request, saml2RequestResponse);
105105

106+
return Read(request, saml2RequestResponse, messageName, true);
107+
}
108+
109+
protected override Saml2Request Read(HttpRequest request, Saml2Request saml2RequestResponse, string messageName, bool validateXmlSignature)
110+
{
106111
if (!"POST".Equals(request.Method, StringComparison.InvariantCultureIgnoreCase))
107112
throw new InvalidSaml2BindingException("Not HTTP POST Method.");
108113

109114
if (!request.Form.AllKeys.Contains(messageName))
110115
throw new Saml2BindingException("HTTP Form does not contain " + messageName);
111116

112-
return Read(request, saml2RequestResponse, messageName, true);
113-
}
114-
115-
protected override Saml2Request Read(HttpRequest request, Saml2Request saml2RequestResponse, string messageName, bool validateXmlSignature)
116-
{
117117
if (request.Form.AllKeys.Contains(Saml2Constants.Message.RelayState))
118118
{
119119
RelayState = request.Form[Saml2Constants.Message.RelayState];

src/ITfoxtec.Identity.Saml2/ITfoxtec.Identity.Saml2.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ Tested for compliance with AD FS, Azure AD and Azure AD B2C. Furthermore, the Da
2323
<PackageTags>SAML SAML 2.0 SAML2.0 SAML2 SAML 2 SAML-P SAMLP SSO Identity Provider (IdP) Relying Party (RP) Authentication Metadata OIOSAML NemLog-in</PackageTags>
2424
<NeutralLanguage>en-US</NeutralLanguage>
2525
<PackageIconUrl>https://itfoxtec.com/favicon.ico</PackageIconUrl>
26-
<AssemblyVersion>4.5.0.0</AssemblyVersion>
27-
<FileVersion>4.5.0.0</FileVersion>
26+
<AssemblyVersion>4.5.1.0</AssemblyVersion>
27+
<FileVersion>4.5.1.0</FileVersion>
2828
<Copyright>Copyright © 2021</Copyright>
29-
<Version>4.5.0</Version>
29+
<Version>4.5.1</Version>
3030
<SignAssembly>true</SignAssembly>
3131
<AssemblyOriginatorKeyFile>ITfoxtec.SAML2.snk</AssemblyOriginatorKeyFile>
3232
<DelaySign>false</DelaySign>

0 commit comments

Comments
 (0)