Fiks convert not null bool to bool? problem.

Author: Revsgaard

src/ITfoxtec.Identity.Saml2/Util/GenericTypeConverter.cs

@@ -75,7 +75,7 @@ internal static T ConvertElement<T>(XmlNode xmlNode)
             {
                 return GenericConvertValue<T, NameIdPolicy>(new NameIdPolicy
                 {
-                    AllowCreate = GenericConvertValue<bool?, string>(xmlNode.Attributes[Schemas.Saml2Constants.Message.AllowCreate]?.Value),
+                    AllowCreate = GenericConvertValueToNullable<bool>(xmlNode.Attributes[Schemas.Saml2Constants.Message.AllowCreate]?.Value),
                     Format = xmlNode.Attributes[Schemas.Saml2Constants.Message.Format]?.Value,
                     SPNameQualifier = xmlNode.Attributes[Schemas.Saml2Constants.Message.SpNameQualifier]?.Value
                 });
@@ -109,5 +109,17 @@ static T GenericConvertValue<T, U>(U value)
         {
             return (T)Convert.ChangeType(value, typeof(T));
         }
+
+        static T? GenericConvertValueToNullable<T>(string value) where T : struct
+        {
+            if (string.IsNullOrWhiteSpace(value))
+            {
+                return null;
+            }
+            else
+            {
+                return (T)Convert.ChangeType(value, typeof(T));
+            }
+        }
     }
 }

test/TestWebAppCore/Controllers/AuthController.cs

@@ -35,7 +35,7 @@ public IActionResult Login(string returnUrl = null)
             {
                 //ForceAuthn = true,
                 Subject = new Subject { NameID = new NameID { ID = "abcd" } },
-                //NameIdPolicy = new NameIdPolicy { AllowCreate = true, Format = "urn:oasis:names:tc:SAML:2.0:nameid-format:persistent" },
+                NameIdPolicy = new NameIdPolicy { AllowCreate = true, Format = "urn:oasis:names:tc:SAML:2.0:nameid-format:persistent" },
                 //RequestedAuthnContext = new RequestedAuthnContext
                 //{
                 //    Comparison = AuthnContextComparisonTypes.Exact,