add support for rom.bin types. add support in mgb to overload the console, region and system.

Author: ITotalJustice

src/core/sms_vdp.c

@@ -913,7 +913,8 @@ static void vdp_parse_sg_sprites(struct SMS_Core* sms, int line)
 
     const uint16_t sprite_attribute_base_addr = vdp_get_sprite_attribute_base_addr(sms);
     const uint8_t sprite_size = vdp_get_sprite_height(sms);
-    const int sprite_eof = 208;
+    // https://konamiman.github.io/MSX2-Technical-Handbook/md/Chapter4a.html#sprite-attribute-table
+    const int sprite_eof = 208; // 216 in mode 2
 
     for (uint8_t i = 0; i < 128; i += 4)
     {

src/mgb/mgb.c

@@ -68,6 +68,10 @@ struct mgb
     // uint8_t sram_data[SMS_SAVE_SIZE_MAX];
     // size_t sram_size;
     // bool has_sram;
+
+    int region;
+    int console;
+    int system;
 };
 
 
@@ -315,7 +319,12 @@ static bool loadrom(const struct LoadRomConfig* config)
         system_hint = SMS_System_SG1000;
     }
 
-    if (!SMS_loadromEx(mgb.sms, mgb.rom_data, mgb.rom_size, system_hint, -1, -1))
+    if (mgb.system != -1)
+    {
+        system_hint = mgb.system;
+    }
+
+    if (!SMS_loadromEx(mgb.sms, mgb.rom_data, mgb.rom_size, system_hint, mgb.region, mgb.console))
     {
         mgb_log_err("[MGB] fail to gb load rom\n");
         goto fail;
@@ -798,7 +807,7 @@ static bool patch_rom(const struct LoadRomConfig* config)
     // cart ram. so we dump the ram and then re-load it.
     mgb_save_save_file(NULL);
 
-    if (!SMS_loadromEx(mgb.sms, data, new_size, -1, -1, -1))
+    if (!SMS_loadromEx(mgb.sms, data, new_size, mgb.system, mgb.region, mgb.console))
     {
         goto fail;
     }
@@ -878,7 +887,12 @@ bool mgb_patch_rom_data(const char* path, const uint8_t* data, size_t size)
 bool mgb_init(struct SMS_Core* sms)
 {
     memset(&mgb, 0, sizeof(struct mgb));
+
     mgb.sms = sms;
+    mgb_set_region(-1);
+    mgb_set_console(-1);
+    mgb_set_system(-1);
+
     return true;
 }
 
@@ -1073,12 +1087,29 @@ struct StateInfo* mgb_load_state_info_file(const char* path, bool load_png)
 
 void mgb_free_state_info(struct StateInfo* info)
 {
-    if (info) {
-        if (info->png) {
+    if (info)
+    {
+        if (info->png)
+        {
             free(info->png);
         }
 
         memset(info, 0, sizeof(*info));
         free(info);
     }
 }
+
+void mgb_set_region(int value)
+{
+    mgb.region = value;
+}
+
+void mgb_set_console(int value)
+{
+    mgb.console = value;
+}
+
+void mgb_set_system(int value)
+{
+    mgb.system = value;
+}

src/mgb/mgb.h

@@ -110,6 +110,11 @@ const char* mgb_rom_path(void);
 struct StateInfo* mgb_load_state_info_file(const char* path, bool load_png);
 void mgb_free_state_info(struct StateInfo* info);
 
+// set to -1 (default) to auto detect.
+void mgb_set_region(int value);
+void mgb_set_console(int value);
+void mgb_set_system(int value);
+
 #ifdef __cplusplus
 }
 #endif

src/mgb/util.c

@@ -230,6 +230,7 @@ enum ExtensionType util_get_extension_type(
         { ".sms", ExtensionType_SMS },
         { ".gg", ExtensionType_GG },
         { ".sg", ExtensionType_SG },
+        { ".bin", ExtensionType_BIN },
 
         // [zip]
         { ".zip", ExtensionType_ZIP },

src/mgb/util.h

@@ -36,7 +36,8 @@ enum ExtensionType {
     ExtensionType_SMS   = 1 << 12,
     ExtensionType_GG   = 1 << 13,
     ExtensionType_SG   = 1 << 14,
-    ExtensionType_ROM = ExtensionType_SMS | ExtensionType_GG | ExtensionType_SG,
+    ExtensionType_BIN   = 1 << 15,
+    ExtensionType_ROM = ExtensionType_SMS | ExtensionType_GG | ExtensionType_SG | ExtensionType_BIN,
 
     ExtensionType_REGULAR = ExtensionType_UNK | ExtensionType_ROM |
         ExtensionType_SAVE | ExtensionType_RTC | ExtensionType_STATE |