Skip to content

[Feature Request] Support rectangular dimensional pooling and stride in maxPool #8

Description

@ShreyasKhandekar

maxPool currently only takes in a single integral parameter which creates a square kernel.

It should be simple enough to implement this to also support passing a two-tuple to support arbitrary kernel sizes.

See https://pytorch.org/docs/stable/generated/torch.nn.MaxPool1d.html#maxpool1d. kernel_size can be int or Tuple[int].

Ex:

    x = x.maxPool(3); // Square 2D pooling

instead of

    x = x.maxPool((3,2));

We should also add the other parameters that pytorch supports like stride, padding, dilation etc.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions