Add JUnit tests for Parser Class

IceBear789 · IceBear789 · commit 0b4cc60c54ec · 2021-01-27T20:43:44.000+08:00
Duke currently does not have tests for Parser Class.

There is a high chance a bug may occur in the Parser class in the
future, when new code is added.

Implement JUnit tests to ensure that the Parser class still functions
correctly after future changes.

JUnit tests were chosen due to their convenience.
diff --git a/src/main/java/main/java/main/java/Deadline.java b/src/main/java/main/java/main/java/Deadline.java
diff --git a/src/main/java/main/java/main/java/Duke.java b/src/main/java/main/java/main/java/Duke.java
@@ -42,7 +42,7 @@ public Duke() {
         System.out.println("What can I do for you?");
     }
 
-    public void process(String[] processedInput) {
+    private void process(String[] processedInput) {
         this.ui.processCommand(processedInput, this.taskList);
     }
 }
diff --git a/src/main/java/main/java/main/java/DukeException.java b/src/main/java/main/java/main/java/DukeException.java
@@ -1,6 +1,6 @@
 package main.java;
 
-class DukeException extends Exception {
+public class DukeException extends Exception {
     private final String errorMessage;
 
     public DukeException(String error) {
diff --git a/src/main/java/main/java/main/java/Event.java b/src/main/java/main/java/main/java/Event.java
@@ -14,7 +14,7 @@ public Event(String eventInfo, boolean isDone, LocalDate date) {
         this.date = date;
     }
 
-    public String getDate() {
+    protected String getDate() {
         return Task.printDate(this.date);
     }
 
diff --git a/src/main/java/main/java/main/java/Parser.java b/src/main/java/main/java/main/java/Parser.java
@@ -4,7 +4,7 @@
 import java.time.format.DateTimeParseException;
 import java.util.ArrayList;
 
-class Parser {
+public class Parser{
 
     public String[] processCommand (String input) throws DukeException {
         String command = input.split(" ")[0];
@@ -25,7 +25,7 @@ public String[] processCommand (String input) throws DukeException {
         }
     }
 
-    public String[] processList(String input) throws DukeException {
+    private String[] processList(String input) throws DukeException {
         String[] result = new String[1];
         String[] processedInput = input.split(" ");
         if (processedInput.length > 1) {
@@ -36,7 +36,7 @@ public String[] processList(String input) throws DukeException {
         return result;
     }
 
-    public String[] processDone(String input) throws DukeException {
+    private String[] processDone(String input) throws DukeException {
         String[] result = new String[2];
         String[] processedInput = input.split(" ");
         if (processedInput.length == 1) {
@@ -54,7 +54,7 @@ public String[] processDone(String input) throws DukeException {
         }
     }
 
-    public String[] processDelete(String input) throws DukeException {
+    private String[] processDelete(String input) throws DukeException {
         String[] result = new String[2];
         String[] processedInput = input.split(" ");
         if (processedInput.length == 1) {
@@ -72,7 +72,7 @@ public String[] processDelete(String input) throws DukeException {
         }
     }
 
-    public String[] processToDo(String input) throws DukeException {
+    private String[] processToDo(String input) throws DukeException {
         String[] result = new String[2];
         String[] processedInput = input.split(" ");
         if (processedInput.length == 1) {
@@ -85,7 +85,7 @@ public String[] processToDo(String input) throws DukeException {
         return result;
     }
 
-    public String[] processDeadLine(String input) throws DukeException {
+    private String[] processDeadLine(String input) throws DukeException {
         String[] result = new String[3];
         String[] processedInput = input.substring(9).split("/by");
         if (processedInput.length == 0) {
@@ -104,7 +104,7 @@ public String[] processDeadLine(String input) throws DukeException {
         }
     }
 
-    public String[] processEvent(String input) throws DukeException {
+    private String[] processEvent(String input) throws DukeException {
         String[] result = new String[3];
         String[] processedInput = input.substring(6).split("/at");
         if (processedInput.length == 0) {
diff --git a/src/main/java/main/java/main/java/Storage.java b/src/main/java/main/java/main/java/Storage.java
diff --git a/src/main/java/main/java/main/java/Task.java b/src/main/java/main/java/main/java/Task.java
@@ -15,7 +15,7 @@ public Task(String taskName, boolean isDone) {
         this.isDone = isDone;
     }
 
-    public void completeTask() {
+    protected void completeTask() {
         this.isDone = true;
     }
 
@@ -28,7 +28,7 @@ public static String printDate(LocalDate date) {
                 " " + day + " " + year;
     }
 
-    public boolean isComplete() {
+    protected boolean isComplete() {
         return this.isDone;
     }
 }
diff --git a/src/main/java/main/java/main/java/TaskList.java b/src/main/java/main/java/main/java/TaskList.java
@@ -21,15 +21,15 @@ public TaskList() {
         }
     }
 
-    public void listTask() {
+    protected void listTask() {
         System.out.println("Here are the tasks in your list:");
         for (int i = 0; i < taskList.size(); i++) {
-            Task currTask = taskList.get(i);
+            main.java.Task currTask = taskList.get(i);
             System.out.println(i + 1 + "." + currTask);
         }
     }
 
-    public void doneTask(int index) throws DukeException {
+    protected void doneTask(int index) throws DukeException {
         if (this.taskList.size() >= index) {
             Task currTask = this.taskList.get(index - 1);
             currTask.completeTask();
diff --git a/src/main/java/main/java/main/java/ToDo.java b/src/main/java/main/java/main/java/ToDo.java
diff --git a/src/main/java/main/java/main/java/Ui.java b/src/main/java/main/java/main/java/Ui.java
@@ -3,7 +3,7 @@
 
 class Ui {
 
-    public void processCommand(String[] input, TaskList taskList) {
+    protected void processCommand(String[] input, TaskList taskList) {
         try {
             if (input[0].equals("list")) {
                 taskList.listTask();
diff --git a/src/test/java/main/javatest/ParserTest.java b/src/test/java/main/javatest/ParserTest.java
@@ -0,0 +1,32 @@
+package main.javatest;
+
+import main.java.DukeException;
+import main.java.Parser;
+import org.junit.jupiter.api.Test;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.fail;
+
+public class ParserTest {
+
+    @Test
+    public void ParserEvent() {
+        Parser parser = new Parser();
+        String[] actual = {"event","Dinner","2019-12-11"};
+        try {
+            assertEquals(actual[0], parser.processCommand("event Dinner /at 2019-12-11")[0]);
+        } catch (DukeException e) {
+            System.out.println(e);
+        }
+    }
+
+    @Test
+    public void ParserDeadline() {
+        Parser parser = new Parser();
+        try {
+            assertEquals(null, parser.processCommand("deadline Dinner 2019-12-11"));
+            fail();
+        } catch (DukeException e) {
+            assertEquals(new DukeException("Invalid description of deadline").toString(),e.toString());
+        }
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public Duke() {`
`42`	`42`	`System.out.println("What can I do for you?");`
`43`	`43`	`}`
`44`	`44`
`45`		`- public void process(String[] processedInput) {`
	`45`	`+ private void process(String[] processedInput) {`
`46`	`46`	`this.ui.processCommand(processedInput, this.taskList);`
`47`	`47`	`}`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ public Event(String eventInfo, boolean isDone, LocalDate date) {`
`14`	`14`	`this.date = date;`
`15`	`15`	`}`
`16`	`16`
`17`		`- public String getDate() {`
	`17`	`+ protected String getDate() {`
`18`	`18`	`return Task.printDate(this.date);`
`19`	`19`	`}`
`20`	`20`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`import java.time.format.DateTimeParseException;`
`5`	`5`	`import java.util.ArrayList;`
`6`	`6`
`7`		`-class Parser {`
	`7`	`+public class Parser{`
`8`	`8`
`9`	`9`	`public String[] processCommand (String input) throws DukeException {`
`10`	`10`	`String command = input.split(" ")[0];`
`@@ -25,7 +25,7 @@ public String[] processCommand (String input) throws DukeException {`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`
`28`		`- public String[] processList(String input) throws DukeException {`
	`28`	`+ private String[] processList(String input) throws DukeException {`
`29`	`29`	`String[] result = new String[1];`
`30`	`30`	`String[] processedInput = input.split(" ");`
`31`	`31`	`if (processedInput.length > 1) {`
`@@ -36,7 +36,7 @@ public String[] processList(String input) throws DukeException {`
`36`	`36`	`return result;`
`37`	`37`	`}`
`38`	`38`
`39`		`- public String[] processDone(String input) throws DukeException {`
	`39`	`+ private String[] processDone(String input) throws DukeException {`
`40`	`40`	`String[] result = new String[2];`
`41`	`41`	`String[] processedInput = input.split(" ");`
`42`	`42`	`if (processedInput.length == 1) {`
`@@ -54,7 +54,7 @@ public String[] processDone(String input) throws DukeException {`
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`
`57`		`- public String[] processDelete(String input) throws DukeException {`
	`57`	`+ private String[] processDelete(String input) throws DukeException {`
`58`	`58`	`String[] result = new String[2];`
`59`	`59`	`String[] processedInput = input.split(" ");`
`60`	`60`	`if (processedInput.length == 1) {`
`@@ -72,7 +72,7 @@ public String[] processDelete(String input) throws DukeException {`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`
`75`		`- public String[] processToDo(String input) throws DukeException {`
	`75`	`+ private String[] processToDo(String input) throws DukeException {`
`76`	`76`	`String[] result = new String[2];`
`77`	`77`	`String[] processedInput = input.split(" ");`
`78`	`78`	`if (processedInput.length == 1) {`
`@@ -85,7 +85,7 @@ public String[] processToDo(String input) throws DukeException {`
`85`	`85`	`return result;`
`86`	`86`	`}`
`87`	`87`
`88`		`- public String[] processDeadLine(String input) throws DukeException {`
	`88`	`+ private String[] processDeadLine(String input) throws DukeException {`
`89`	`89`	`String[] result = new String[3];`
`90`	`90`	`String[] processedInput = input.substring(9).split("/by");`
`91`	`91`	`if (processedInput.length == 0) {`
`@@ -104,7 +104,7 @@ public String[] processDeadLine(String input) throws DukeException {`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`		`- public String[] processEvent(String input) throws DukeException {`
	`107`	`+ private String[] processEvent(String input) throws DukeException {`
`108`	`108`	`String[] result = new String[3];`
`109`	`109`	`String[] processedInput = input.substring(6).split("/at");`
`110`	`110`	`if (processedInput.length == 0) {`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public Task(String taskName, boolean isDone) {`
`15`	`15`	`this.isDone = isDone;`
`16`	`16`	`}`
`17`	`17`
`18`		`- public void completeTask() {`
	`18`	`+ protected void completeTask() {`
`19`	`19`	`this.isDone = true;`
`20`	`20`	`}`
`21`	`21`
`@@ -28,7 +28,7 @@ public static String printDate(LocalDate date) {`
`28`	`28`	`" " + day + " " + year;`
`29`	`29`	`}`
`30`	`30`
`31`		`- public boolean isComplete() {`
	`31`	`+ protected boolean isComplete() {`
`32`	`32`	`return this.isDone;`
`33`	`33`	`}`
`34`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,15 +21,15 @@ public TaskList() {`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`
`24`		`- public void listTask() {`
	`24`	`+ protected void listTask() {`
`25`	`25`	`System.out.println("Here are the tasks in your list:");`
`26`	`26`	`for (int i = 0; i < taskList.size(); i++) {`
`27`		`- Task currTask = taskList.get(i);`
	`27`	`+ main.java.Task currTask = taskList.get(i);`
`28`	`28`	`System.out.println(i + 1 + "." + currTask);`
`29`	`29`	`}`
`30`	`30`	`}`
`31`	`31`
`32`		`- public void doneTask(int index) throws DukeException {`
	`32`	`+ protected void doneTask(int index) throws DukeException {`
`33`	`33`	`if (this.taskList.size() >= index) {`
`34`	`34`	`Task currTask = this.taskList.get(index - 1);`
`35`	`35`	`currTask.completeTask();`