Merge pull request #7162 from Icinga/bugfix/cli-no-command-status-code

CLI: Return non-zero on unknown sub commands

Author: Michael Friedrich

icinga-app/icinga.cpp

@@ -327,8 +327,13 @@ static int Main()
 	po::variables_map vm;
 
 	try {
-		CLICommand::ParseCommand(argc, argv, visibleDesc, hiddenDesc, positionalDesc,
-			vm, cmdname, command, autocomplete);
+		if (!CLICommand::ParseCommand(argc, argv, visibleDesc, hiddenDesc, positionalDesc,
+			vm, cmdname, command, autocomplete)) {
+
+			Log(LogCritical, "icinga-app")
+				<< "Command parsing error. Try '--help'.";
+			return EXIT_FAILURE;
+		}
 	} catch (const std::exception& ex) {
 		Log(LogCritical, "icinga-app")
 			<< "Error while parsing command-line options: " << ex.what();

lib/cli/clicommand.cpp

@@ -200,9 +200,12 @@ bool CLICommand::ParseCommand(int argc, char **argv, po::options_description& vi
 		visibleDesc.add(vdesc);
 	}
 
-	if (autocomplete || (tried_command && !command))
+	if (autocomplete)
 		return true;
 
+	if (tried_command && !command)
+		return false;
+
 	po::options_description adesc;
 	adesc.add(visibleDesc);
 	adesc.add(hiddenDesc);