Skip to content

Spawn Configuration::Concurrency process managers #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Spawn Configuration::Concurrency process managers #8269

wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Sep 22, 2020 •
edited
Loading

... and not just one to increase checks/time.

fixes #7600
fixes #7332
closes #7744
closes #7984
closes #7425

@icinga-probot icinga-probot bot added area/checks Check execution and results bug Something isn't working labels Sep 22, 2020
@icinga-probot icinga-probot bot added this to the 2.12.1 milestone Sep 22, 2020
@Al2Klimov Al2Klimov requested a review from N-o-X September 22, 2020 11:00
N-o-X
N-o-X previously approved these changes Sep 22, 2020
View reviewed changes
@Al2Klimov Al2Klimov mentioned this pull request Sep 22, 2020
Closed
@N-o-X N-o-X self-requested a review September 22, 2020 14:28
@N-o-X
Copy link
Contributor

N-o-X commented Sep 23, 2020

We've had a few very good benchmarks with those changes in a few test setups (#8196 (comment)), but #7984 (comment) doesn't look as expected. We'll continue testing this.

@Al2Klimov Al2Klimov marked this pull request as draft September 23, 2020 08:25
@Al2Klimov Al2Klimov removed the request for review from N-o-X September 23, 2020 08:26
@Al2Klimov Al2Klimov mentioned this pull request Sep 23, 2020
Merged
@Al2Klimov
Copy link
Member Author

50k checks/m

Performance seems similar to Go variant.

177f930

Bildschirmfoto 2020-09-24 um 12 05 45

105d09c

Bildschirmfoto 2020-09-24 um 12 05 51

a841876

Bildschirmfoto 2020-09-24 um 12 05 57

@Al2Klimov
Copy link
Member Author

100k checks/m

Performance seems similar to Go variant.

105d09c

Bildschirmfoto 2020-09-24 um 12 28 32

a841876

Bildschirmfoto 2020-09-24 um 12 28 39

@Al2Klimov
Copy link
Member Author

200k checks/m

Performance seems similar to Go variant.

105d09c

Bildschirmfoto 2020-09-24 um 12 51 43

a841876

Bildschirmfoto 2020-09-24 um 12 51 53

@Al2Klimov
Copy link
Member Author

250k checks/m

105d09c

Bildschirmfoto 2020-09-24 um 13 36 41

a841876

Bildschirmfoto 2020-09-24 um 13 36 49

@Al2Klimov
Copy link
Member Author

300k/m

Break even.

This one

Bildschirmfoto 2020-09-24 um 16 12 19

Go

Bildschirmfoto 2020-09-24 um 16 12 30

@Al2Klimov Al2Klimov changed the base branch from support/2.12 to master September 24, 2020 14:16
@Al2Klimov Al2Klimov modified the milestones: 2.12.1, 2.13.0 Sep 24, 2020
@Al2Klimov Al2Klimov added enhancement New feature or request and removed bug Something isn't working labels Sep 24, 2020
@Al2Klimov Al2Klimov requested a review from N-o-X September 24, 2020 14:20
@Al2Klimov Al2Klimov marked this pull request as ready for review September 24, 2020 14:20
@icinga-probot icinga-probot bot closed this Sep 24, 2020
@icinga-probot
Copy link
Contributor

icinga-probot bot commented Sep 24, 2020

Closed this issue because #8276 has been merged.

@icinga-probot icinga-probot bot removed this from the 2.13.0 milestone Sep 24, 2020
@Al2Klimov Al2Klimov reopened this Sep 24, 2020
@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Sep 24, 2020
@Al2Klimov Al2Klimov force-pushed the feature/procspawn-concurrency branch from c53b9ae to 6a10405 Compare December 14, 2020 14:52
@julianbrost julianbrost removed this from the 2.13.0 milestone May 31, 2021
@julianbrost julianbrost added this to the 2.14.0 milestone May 31, 2021
@Al2Klimov
Copy link
Member Author

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Aug 4, 2021
@julianbrost julianbrost removed this from the 2.14.0 milestone Jan 12, 2023
@Al2Klimov
Copy link
Member Author

For the record: due to the default concurrency limits this won't blow up any box by default. It will just allow the admin to raise the limits and something happens.

@Al2Klimov Al2Klimov force-pushed the feature/procspawn-concurrency branch 2 times, most recently from 895f1d9 to 8a46574 Compare August 16, 2023 09:27
@Al2Klimov Al2Klimov removed the request for review from N-o-X November 17, 2023 11:30
@Al2Klimov Al2Klimov mentioned this pull request Dec 4, 2023
Merged
@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Jan 21, 2025
@Al2Klimov Al2Klimov force-pushed the feature/procspawn-concurrency branch from 8a46574 to 0a1406d Compare January 21, 2025 10:38
Al2Klimov
Al2Klimov commented Jan 21, 2025
View reviewed changes
@Al2Klimov Al2Klimov marked this pull request as draft January 21, 2025 10:50
@Al2Klimov Al2Klimov marked this pull request as ready for review February 3, 2025 16:56
@Al2Klimov Al2Klimov force-pushed the feature/procspawn-concurrency branch from 0a1406d to 0197d81 Compare February 3, 2025 17:00
@julianbrost julianbrost removed this from the 2.15.0 milestone Apr 8, 2025
@Al2Klimov
Spawn Configuration::Concurrency process managers
f493794 
and not just one to increase checks/time.
@Al2Klimov Al2Klimov force-pushed the feature/procspawn-concurrency branch from 0197d81 to f493794 Compare April 30, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-X N-o-X N-o-X left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/checks Check execution and results cla/signed enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@Al2Klimov @N-o-X @julianbrost