Skip to content

Some stylesheet problems and suggestions #2

@chengluyu

Description

@chengluyu

I was cleaning my GitHub notifications and I saw issue #1. So I reviewed some CSS code and found few problems.

I also have some general suggestions.

  • Use relative units. Compared to absolute unit (e.g. px), relative units (e.g. rem and em) make you design more consistent. You can also get other benefits, for example, you can easily scale up and down your components.
  • Use less flex box. I found flex being used everywhere even simple cases. In 50% cases, you can use simpler solution rather than flex.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions