Skip to content

Commit 5a0cfb2

Browse files
author
Giuseppe De Marco
authored
Merge pull request #359 from Gee19/master
fix: XSS in next_path url param
2 parents 16bb169 + aa3b381 commit 5a0cfb2

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

djangosaml2/utils.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,8 @@ def validate_referral_url(request, url):
110110

111111
if not url_has_allowed_host_and_scheme(url=url, allowed_hosts=saml_allowed_hosts):
112112
return get_fallback_login_redirect_url()
113-
return url
113+
114+
return urllib.parse.quote(url, safe="/")
114115

115116

116117
def saml2_from_httpredirect_request(url):

setup.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def read(*rnames):
2727

2828
setup(
2929
name="djangosaml2",
30-
version="1.5.3",
30+
version="1.5.4",
3131
description="pysaml2 integration for Django",
3232
long_description=read("README.md"),
3333
long_description_content_type="text/markdown",
@@ -61,9 +61,5 @@ def read(*rnames):
6161
packages=find_packages(exclude=["tests", "tests.*"]),
6262
include_package_data=True,
6363
zip_safe=False,
64-
install_requires=[
65-
"defusedxml>=0.4.1",
66-
"Django>=2.2,<5",
67-
"pysaml2>=6.5.1",
68-
],
64+
install_requires=["defusedxml>=0.4.1", "Django>=2.2,<5", "pysaml2>=6.5.1"],
6965
)

0 commit comments

Comments
 (0)