Allow blank, null, string.Empty route pattern (#60)

Author: IeuanWalker

example/ExampleApi/Endpoints/Todos/GetAll/GetAllTodosEndpoint.cs

@@ -19,7 +19,7 @@ public static void Configure(RouteHandlerBuilder builder)
 	{
 		builder
 			.Group<TodoEndpointGroup>()
-			.Get("/")
+			.Get()
 			.WithSummary("Get all todos")
 			.WithDescription("Retrieves all todos from the store")
 			.Version(1.0);

src/IeuanWalker.MinimalApi.Endpoints.Generator/Helpers/HttpVerbRouteHelpers.cs

@@ -80,14 +80,49 @@ public static (HttpVerb verb, string pattern)? GetVerbAndPattern(this TypeDeclar
 		{
 			HttpVerb? verb = ConvertToHttpVerb(verbMemberAccess.Name.Identifier.ValueText);
 
+			if (verb is null)
+			{
+				return null;
+			}
+
+			if (firstHttpVerbCall.ArgumentList.Arguments.Count == 0)
+			{
+				return (verb.Value, string.Empty);
+			}
+
 			// Try to extract the route pattern argument
-			if (verb is not null && firstHttpVerbCall.ArgumentList.Arguments.Count > 0)
+			if (firstHttpVerbCall.ArgumentList.Arguments.Count > 0)
 			{
 				ArgumentSyntax argument = firstHttpVerbCall.ArgumentList.Arguments[0];
 
-				if (argument.Expression is LiteralExpressionSyntax literal && literal.Token.IsKind(SyntaxKind.StringLiteralToken))
+				if (argument.Expression is LiteralExpressionSyntax literal)
+				{
+					if (literal.Token.IsKind(SyntaxKind.NullKeyword))
+					{
+						return (verb.Value, string.Empty);
+					}
+
+					if (literal.Token.IsKind(SyntaxKind.StringLiteralToken))
+					{
+						return (verb.Value, literal.Token.ValueText);
+					}
+				}
+				else if (argument.Expression is MemberAccessExpressionSyntax memberAccess)
 				{
-					return (verb.Value, literal.Token.ValueText);
+					// Check for string.Empty and String.Empty
+					if (memberAccess.Expression is PredefinedTypeSyntax predefinedType
+						&& predefinedType.Keyword.IsKind(SyntaxKind.StringKeyword)
+						&& memberAccess.Name.Identifier.ValueText == "Empty")
+					{
+						return (verb.Value, string.Empty);
+					}
+
+					if (memberAccess.Expression is IdentifierNameSyntax identifierName
+						&& identifierName.Identifier.ValueText == "String"
+						&& memberAccess.Name.Identifier.ValueText == "Empty")
+					{
+						return (verb.Value, string.Empty);
+					}
 				}
 			}
 		}

src/IeuanWalker.MinimalApi.Endpoints/Extensions/MapEndpointExtensions.cs

@@ -10,31 +10,31 @@ public static class MapEndpointExtensions
 {
 	[ExcludeFromCodeCoverage]
 	[SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
-	public static RouteHandlerBuilder Get(this RouteHandlerBuilder builder, [StringSyntax("Route")] string pattern)
+	public static RouteHandlerBuilder Get(this RouteHandlerBuilder builder, [StringSyntax("Route")] string? pattern = null)
 	{
 		return builder;
 	}
 	[ExcludeFromCodeCoverage]
 	[SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
-	public static RouteHandlerBuilder Post(this RouteHandlerBuilder builder, [StringSyntax("Route")] string pattern)
+	public static RouteHandlerBuilder Post(this RouteHandlerBuilder builder, [StringSyntax("Route")] string? pattern = null)
 	{
 		return builder;
 	}
 	[ExcludeFromCodeCoverage]
 	[SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
-	public static RouteHandlerBuilder Put(this RouteHandlerBuilder builder, [StringSyntax("Route")] string pattern)
+	public static RouteHandlerBuilder Put(this RouteHandlerBuilder builder, [StringSyntax("Route")] string? pattern = null)
 	{
 		return builder;
 	}
 	[ExcludeFromCodeCoverage]
 	[SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
-	public static RouteHandlerBuilder Patch(this RouteHandlerBuilder builder, [StringSyntax("Route")] string pattern)
+	public static RouteHandlerBuilder Patch(this RouteHandlerBuilder builder, [StringSyntax("Route")] string? pattern = null)
 	{
 		return builder;
 	}
 	[ExcludeFromCodeCoverage]
 	[SuppressMessage("Style", "IDE0060:Remove unused parameter", Justification = "<Pending>")]
-	public static RouteHandlerBuilder Delete(this RouteHandlerBuilder builder, [StringSyntax("Route")] string pattern)
+	public static RouteHandlerBuilder Delete(this RouteHandlerBuilder builder, [StringSyntax("Route")] string? pattern = null)
 	{
 		return builder;
 	}

tests/IeuanWalker.MinimalApi.Endpoints.Generator.Tests/Helpers/HttpVerbRouteHelpersTests.cs

@@ -156,7 +156,7 @@ public static void Configure(RouteHandlerBuilder builder)
 	}
 
 	[Fact]
-	public void GetVerbAndPattern_WithHttpVerbButNoRoutePattern_ReturnsNull()
+	public void GetVerbAndPattern_WithHttpVerbButNoRoutePattern_DefaultToEmptyString()
 	{
 		// Arrange
 		const string sourceCode = """
@@ -176,7 +176,63 @@ public static void Configure(RouteHandlerBuilder builder)
 		(HttpVerb verb, string pattern)? result = typeDeclaration.GetVerbAndPattern("TestEndpoint", diagnostics);
 
 		// Assert
-		result.ShouldBeNull();
+		result.ShouldNotBeNull();
+		result.Value.verb.ShouldBe(HttpVerb.Get);
+		result.Value.pattern.ShouldBe(string.Empty);
+		diagnostics.ShouldBeEmpty();
+	}
+
+	[Fact]
+	public void GetVerbAndPattern_WithHttpVerbButStringEmptyPattern_DefaultToEmptyString()
+	{
+		// Arrange
+		const string sourceCode = """
+			public class TestEndpoint
+			{
+				public static void Configure(RouteHandlerBuilder builder)
+				{
+					builder.Get(string.Empty);
+				}
+			}
+			""";
+
+		TypeDeclarationSyntax typeDeclaration = ParseTypeDeclaration(sourceCode);
+		List<DiagnosticInfo> diagnostics = [];
+
+		// Act
+		(HttpVerb verb, string pattern)? result = typeDeclaration.GetVerbAndPattern("TestEndpoint", diagnostics);
+
+		// Assert
+		result.ShouldNotBeNull();
+		result.Value.verb.ShouldBe(HttpVerb.Get);
+		result.Value.pattern.ShouldBe(string.Empty);
+		diagnostics.ShouldBeEmpty();
+	}
+
+	[Fact]
+	public void GetVerbAndPattern_WithHttpVerbButStringEmptyV2Pattern_DefaultToEmptyString()
+	{
+		// Arrange
+		const string sourceCode = """
+			public class TestEndpoint
+			{
+				public static void Configure(RouteHandlerBuilder builder)
+				{
+					builder.Get(String.Empty);
+				}
+			}
+			""";
+
+		TypeDeclarationSyntax typeDeclaration = ParseTypeDeclaration(sourceCode);
+		List<DiagnosticInfo> diagnostics = [];
+
+		// Act
+		(HttpVerb verb, string pattern)? result = typeDeclaration.GetVerbAndPattern("TestEndpoint", diagnostics);
+
+		// Assert
+		result.ShouldNotBeNull();
+		result.Value.verb.ShouldBe(HttpVerb.Get);
+		result.Value.pattern.ShouldBe(string.Empty);
 		diagnostics.ShouldBeEmpty();
 	}
 
@@ -378,7 +434,7 @@ public static void Configure(RouteHandlerBuilder builder)
 					var configuredBuilder = builder
 						.WithName("Test")
 						.WithSummary("Test endpoint");
-					
+
 					configuredBuilder.Post("/test");
 				}
 			}