#653: fix crash on attempt to make bounty event while missing permission (#660)

* #653: fix crash on attempt to make bounty event while missing permission

* check permission instead of sending request and catching error

* update changelog

Author: ntseng

ChangeLog.md

@@ -1,5 +1,6 @@
 # BountyBot Change Log
 ## BountyBot Version 2.11.1ib:
+- Fixed a crash when attempting to make an event for a bounty while missing permission
 - Fixed some issues where rank calculation was assigning the incorrect rank or failing to announce rank ups
 ## BountyBot Version 2.11.0fib:
 ### Reaction Toasts

source/frontend/commands/bounty/post.js

@@ -1,8 +1,8 @@
-const { ActionRowBuilder, StringSelectMenuBuilder, ModalBuilder, TextInputBuilder, TextInputStyle, MessageFlags, ComponentType, unorderedList, LabelBuilder, FileUploadBuilder } = require("discord.js");
+const { ActionRowBuilder, StringSelectMenuBuilder, ModalBuilder, TextInputBuilder, TextInputStyle, MessageFlags, ComponentType, unorderedList, LabelBuilder, FileUploadBuilder, PermissionFlagsBits } = require("discord.js");
 const { EmbedLimits } = require("@sapphire/discord.js-utilities");
 const { SubcommandWrapper } = require("../../classes");
 const { Bounty, Hunter } = require("../../../database/models");
-const { emojiFromNumber, textsHaveAutoModInfraction, commandMention, bountyEmbed, bountyControlPanelSelectRow, addCompanyAnnouncementPrefix, syncRankRoles, validateScheduledEventTimestamps, bountyScheduledEventPayload, butIgnoreInteractionCollectorErrors, refreshReferenceChannelScoreboardSeasonal, refreshReferenceChannelScoreboardOverall } = require("../../shared");
+const { emojiFromNumber, textsHaveAutoModInfraction, commandMention, bountyEmbed, bountyControlPanelSelectRow, addCompanyAnnouncementPrefix, syncRankRoles, validateScheduledEventTimestamps, bountyScheduledEventPayload, butIgnoreInteractionCollectorErrors, refreshReferenceChannelScoreboardSeasonal, refreshReferenceChannelScoreboardOverall, isMissingPermissionError } = require("../../shared");
 const { timeConversion } = require("../../../shared");
 const { SKIP_INTERACTION_HANDLING } = require("../../../constants");
 
@@ -129,6 +129,7 @@ module.exports = new SubcommandWrapper("post", "Post your own bounty (+1 XP)",
 					rawBounty.description = description;
 				}
 				const errors = [];
+				const warnings = [];
 
 				const attachmentFileCollection = modalSubmission.fields.getUploadedFiles(imageId);
 				if (attachmentFileCollection) {
@@ -141,7 +142,7 @@ module.exports = new SubcommandWrapper("post", "Post your own bounty (+1 XP)",
 				const startTimestamp = parseInt(modalSubmission.fields.getTextInputValue(startTimestampId));
 				const endTimestamp = parseInt(modalSubmission.fields.getTextInputValue(endTimestampId));
 				if (startTimestamp || endTimestamp) {
-					errors.push(...validateScheduledEventTimestamps(startTimestamp, endTimestamp))
+					errors.push(...validateScheduledEventTimestamps(startTimestamp, endTimestamp));
 				}
 
 				if (errors.length > 0) {
@@ -167,8 +168,12 @@ module.exports = new SubcommandWrapper("post", "Post your own bounty (+1 XP)",
 				let event = null;
 				if (startTimestamp && endTimestamp) {
 					const eventPayload = bountyScheduledEventPayload(title, modalSubmission.member.displayName, rawBounty.slotNumber, description, rawBounty.attachmentURL, startTimestamp, endTimestamp);
-					event = await modalSubmission.guild.scheduledEvents.create(eventPayload);
-					rawBounty.scheduledEventId = event.id;
+					if (modalSubmission.guild.members.me.permissions.has(PermissionFlagsBits.CreateEvents)) {
+						event = await modalSubmission.guild.scheduledEvents.create(eventPayload);
+						rawBounty.scheduledEventId = event.id;
+					} else {
+						warnings.push(`Could not create an Event for this bounty; ${modalSubmission.client.user} is missing permission to create Events.`);
+					}
 				}
 
 				const bounty = await logicLayer.bounties.createBounty(rawBounty);
@@ -177,6 +182,9 @@ module.exports = new SubcommandWrapper("post", "Post your own bounty (+1 XP)",
 				await origin.hunter.reload();
 				const embeds = [bountyEmbed(bounty, modalSubmission.member, origin.hunter.getLevel(origin.company.xpCoefficient), false, origin.company, new Set(), event)];
 				modalSubmission.reply(addCompanyAnnouncementPrefix(origin.company, { content: `${modalSubmission.member} has posted a new bounty:`, embeds })).then(() => {
+					if (warnings.length > 0) {
+						modalSubmission.followUp({ content: `The following issues were encountered while posting your bounty (your bounty was still posted):\n${unorderedList(warnings)}`, flags: MessageFlags.Ephemeral });
+					}
 					if (origin.company.bountyBoardId) {
 						modalSubmission.guild.channels.fetch(origin.company.bountyBoardId).then(bountyBoard => {
 							return bountyBoard.threads.create({