Skip to content

Commit 8b07d46

Browse files
committed
ci(justfile): use PATH-resolved python in v2-models-check
CI failed with `sh: 1: .venv/bin/python: not found`. The recipe hardcoded `.venv/bin/python`, but `.github/workflows/ci.yml` provisions Python via `actions/setup-python@v5` + `pip install -e .[dev]` — no `.venv/` is created on the runner. `just v2-models-check` is the only recipe CI invokes, so the rest of the justfile is left untouched (those recipes are dev-only and devs run them with `.venv` on PATH anyway). Verified: `just v2-models-check` passes locally on the devcontainer (`.venv/bin` on PATH → `python` resolves to the venv) and will resolve to the runner's setup-python interpreter on CI.
1 parent 9c1b701 commit 8b07d46

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

justfile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,13 @@ test-offline:
164164
v2-models-generate:
165165
PYTHONPATH=. .venv/bin/python scripts/v2/generate_v2_models.py
166166

167-
# Check committed v2 generated models are in sync with strict schemas
167+
# Check committed v2 generated models are in sync with strict schemas.
168+
# Uses `python` (PATH-resolved) so the recipe works in CI — where
169+
# `setup-python` installs into the runner env, no `.venv/` — as well as
170+
# in the devcontainer where `.venv/bin` is on PATH after activation. CI
171+
# invokes this recipe via `just v2-models-check`.
168172
v2-models-check:
169-
PYTHONPATH=. .venv/bin/python scripts/v2/generate_v2_models.py --check
173+
PYTHONPATH=. python scripts/v2/generate_v2_models.py --check
170174

171175
# Run LLM repository agent end-to-end with real GIMIE context (no server needed)
172176
# Usage: just v2-run-repo-agent sdsc-ordes/gimie

0 commit comments

Comments
 (0)