Skip to content

Commit 0c6eb55

Browse files
committed
enh: improve version update to handle all queries
1 parent 2dd725e commit 0c6eb55

2 files changed

Lines changed: 33 additions & 5 deletions

File tree

noxfile.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ def bump(session: nox.Session) -> None:
186186
Set to a new IDC index version, use -- <version>, otherwise will use the latest version.
187187
"""
188188
files = (
189-
"scripts/sql/idc_index.sql",
189+
"scripts/sql/",
190+
"assets/",
190191
"tests/test_package.py",
191192
)
192193
_bump(

scripts/python/update_idc_index_version.py

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,36 @@ def update_pyproject_toml(idc_index_version):
4747

4848

4949
def update_sql_scripts(idc_index_version):
50-
pattern = re.compile(r"idc_v\d+")
51-
replacement = f"idc_v{idc_index_version}"
52-
_update_file(ROOT_DIR / "scripts/sql/idc_index.sql", pattern, replacement)
50+
"""Update all SQL files to use the new IDC version.
51+
52+
Updates two types of patterns:
53+
1. idc_vNN in most SQL files (e.g., idc_v23 → idc_v24)
54+
2. DECLARE latest_idc_version INT64 DEFAULT NN; in prior_versions_index.sql
55+
"""
56+
# Pattern 1: Update idc_vNN in all SQL files except prior_versions_index.sql
57+
idc_pattern = re.compile(r"idc_v\d+")
58+
idc_replacement = f"idc_v{idc_index_version}"
59+
60+
# Update all .sql files in scripts/sql except prior_versions_index.sql
61+
sql_dir = ROOT_DIR / "scripts" / "sql"
62+
for sql_file in sql_dir.glob("*.sql"):
63+
if sql_file.name != "prior_versions_index.sql":
64+
_update_file(sql_file, idc_pattern, idc_replacement)
65+
66+
# Update all .sql files in assets
67+
assets_dir = ROOT_DIR / "assets"
68+
if assets_dir.exists():
69+
for sql_file in assets_dir.glob("*.sql"):
70+
_update_file(sql_file, idc_pattern, idc_replacement)
71+
72+
# Pattern 2: Update latest_idc_version in prior_versions_index.sql
73+
prior_versions_file = sql_dir / "prior_versions_index.sql"
74+
if prior_versions_file.exists():
75+
version_pattern = re.compile(r"DECLARE latest_idc_version INT64 DEFAULT \d+;")
76+
version_replacement = (
77+
f"DECLARE latest_idc_version INT64 DEFAULT {idc_index_version};"
78+
)
79+
_update_file(prior_versions_file, version_pattern, version_replacement)
5380

5481

5582
def update_tests(idc_index_version):
@@ -92,7 +119,7 @@ def main():
92119
Complete! Now run:
93120
94121
git switch -c update-to-idc-index-{release}
95-
git add -u scripts/sql/idc_index.sql tests/test_package.py
122+
git add -u scripts/sql/ assets/ tests/test_package.py
96123
git commit -m "Update to IDC index {release}"
97124
git tag -a {release}.0.0 -m "Update to IDC index {release}"
98125
gh pr create --fill --body "Created by update_idc_index_version.py"

0 commit comments

Comments
 (0)