Skip to content

Commit 2b5c191

Browse files
committed
fix: apply codeQL findings + fix test failing
1 parent 6b5e9d0 commit 2b5c191

File tree

3 files changed

+121
-119
lines changed

3 files changed

+121
-119
lines changed

wakis/gridFIT3D.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,8 +352,8 @@ def _prepare_stl_dicts(self):
352352
stl_colors[key] = self.stl_colors[i]
353353
self.stl_colors = stl_colors
354354
except IndexError:
355-
raise Exception('If `stl_colors` is a list, it must have the same length as `stl_solids`.')
356355
self._assign_colors()
356+
print('[!] If `stl_colors` is a list, it must have the same length as `stl_solids`.')
357357

358358
def _mark_cells_in_stl(self):
359359
# Obtain masks with grid cells inside each stl solid
@@ -609,7 +609,7 @@ def _add_logo_widget(self, pl):
609609
print(f'[!] Could not add logo widget: {e}')
610610

611611
def plot_solids(self, bounding_box=False, show_grid=False, anti_aliasing=None,
612-
opacity=1.0, specular=0.5, smooth_shading=False,
612+
opacity=1.0, specular=0.5, smooth_shading=False,
613613
offscreen=False, **kwargs):
614614
"""
615615
Generates a 3D visualization of the imported STL geometries using PyVista.
@@ -680,7 +680,7 @@ def plot_solids(self, bounding_box=False, show_grid=False, anti_aliasing=None,
680680

681681
def plot_stl_mask(self, stl_solid, cmap='viridis', bounding_box=True, show_grid=True,
682682
add_stl='all', stl_opacity=0., stl_colors=None,
683-
xmax=None, ymax=None, zmax=None,
683+
xmax=None, ymax=None, zmax=None,
684684
anti_aliasing='ssaa', smooth_shading=False, offscreen=False):
685685

686686
"""
@@ -716,7 +716,7 @@ def plot_stl_mask(self, stl_solid, cmap='viridis', bounding_box=True, show_grid=
716716
Color(s) of the STL surfaces:
717717
* str → single color for all STL surfaces
718718
* list → per-solid colors, in order
719-
* dict → mapping from STL key to color
719+
* dict → mapping from STL key to color
720720
* None → use default colors from `self.stl_colors`
721721
xmax, ymax, zmax : float, optional
722722
Initial clipping positions along each axis. If None, use the

0 commit comments

Comments
 (0)