Skip to content

Commit b0a7169

Browse files
committed
fix: add logger lines, wrongly skipped during merge + fix MPI workflow action
1 parent 24d34aa commit b0a7169

File tree

2 files changed

+37
-24
lines changed

2 files changed

+37
-24
lines changed

.github/workflows/pull_request_MPI.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ jobs:
2424

2525
# Steps represent a sequence of tasks that will be executed as part of the job
2626
steps:
27+
- name: Checkout repository
28+
uses: actions/checkout@v4
29+
with:
30+
path: wakis
2731
- name: Setup Miniforge
2832
uses: conda-incubator/setup-miniconda@v2
2933
with:
@@ -37,13 +41,8 @@ jobs:
3741
run: |
3842
cd wakis
3943
pip install .['notebook']
40-
4144
- name: Print versions
4245
run: conda list
43-
- name: Checkout wakis
44-
uses: actions/checkout@v4
45-
with:
46-
path: wakis
4746
- name: Run pytest
4847
run: |
4948
cd wakis

wakis/gridFIT3D.py

Lines changed: 33 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -83,27 +83,11 @@ def __init__(self, xmin=None, xmax=None,
8383
stl_colors=None, stl_tol=1e-3,
8484
load_from_h5=None, verbose=1,):
8585

86+
t0 = time.time()
87+
self.logger = Logger()
8688
self.verbose = verbose
8789
self.use_mpi = use_mpi
8890

89-
# stl info
90-
self.stl_solids = stl_solids
91-
self.stl_materials = stl_materials
92-
self.stl_rotate = stl_rotate
93-
self.stl_translate = stl_translate
94-
self.stl_scale = stl_scale
95-
self.stl_colors = stl_colors
96-
self.update_logger(['stl_solids', 'stl_materials'])
97-
if stl_rotate != [0., 0., 0.]:
98-
self.update_logger(['stl_rotate'])
99-
if stl_translate != [0., 0., 0.]:
100-
self.update_logger(['stl_translate'])
101-
if stl_scale != 1.0:
102-
self.update_logger(['stl_scale'])
103-
104-
if stl_solids is not None:
105-
self._prepare_stl_dicts()
106-
10791
# Grid data
10892
# generate from file
10993
if load_from_h5 is not None:
@@ -149,13 +133,33 @@ def __init__(self, xmin=None, xmax=None,
149133
self.dy = np.min(np.diff(self.y))
150134
#self.dz = np.min(np.diff(self.z))
151135
self.dz = (self.zmax - self.zmin)/self.Nz
136+
self.update_logger(['Nx', 'Ny', 'Nz', 'dx', 'dy', 'dz'])
137+
138+
# stl info
139+
self.stl_solids = stl_solids
140+
self.stl_materials = stl_materials
141+
self.stl_rotate = stl_rotate
142+
self.stl_translate = stl_translate
143+
self.stl_scale = stl_scale
144+
self.stl_colors = stl_colors
145+
self.update_logger(['stl_solids', 'stl_materials'])
146+
if stl_rotate != [0., 0., 0.]:
147+
self.update_logger(['stl_rotate'])
148+
if stl_translate != [0., 0., 0.]:
149+
self.update_logger(['stl_translate'])
150+
if stl_scale != 1.0:
151+
self.update_logger(['stl_scale'])
152+
153+
if stl_solids is not None:
154+
self._prepare_stl_dicts()
152155

153156
# refine self.x, self.y, self.z using snap points
154157
self.use_mesh_refinement = use_mesh_refinement
155158
self.refinement_method = refinement_method
156159
self.snap_points = snap_points
157160
self.snap_tol = snap_tol
158161
self.snap_solids = snap_solids # if None, use all stl_solids
162+
self.update_logger(['use_mesh_refinement'])
159163

160164
if self.use_mesh_refinement:
161165
if verbose:
@@ -171,7 +175,6 @@ def __init__(self, xmin=None, xmax=None,
171175
x:[{xmin:.3f}, {xmax:.3f}],\n\
172176
y:[{ymin:.3f}, {ymax:.3f}],\n\
173177
z:[{zmin:.3f}, {zmax:.3f}]')
174-
t0 = time.time()
175178

176179
# MPI subdivide domain
177180
if self.use_mpi:
@@ -1039,6 +1042,17 @@ def load_from_h5(self, filename):
10391042
{list(self.stl_solids.keys())}')
10401043
print(f' * STL solids assigned materials [eps_r, mu_r, sigma]:\n\
10411044
{list(self.stl_materials.values())}')
1045+
1046+
# update logger [TODO: add domain bounds info]
1047+
self.update_logger(['Nx', 'Ny', 'Nz', 'dx', 'dy', 'dz'])
1048+
self.update_logger(['stl_solids', 'stl_materials'])
1049+
if self.stl_rotate != [0., 0., 0.]:
1050+
self.update_logger(['stl_rotate'])
1051+
if self.stl_translate != [0., 0., 0.]:
1052+
self.update_logger(['stl_translate'])
1053+
if self.stl_scale != 1.0:
1054+
self.update_logger(['stl_scale'])
1055+
10421056
def update_logger(self, attrs):
10431057
"""
10441058
Assigns the parameters handed via attrs to the logger

0 commit comments

Comments
 (0)