Skip to content

Commit 89bd559

Browse files
committed
Limit review_rejected default fix to WorkflowResult only
1 parent fd46192 commit 89bd559

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

indico_toolkit/results/review.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,10 @@ def from_dict(review: object) -> "Review":
2323
"""
2424
Create a `Review` from a review dictionary.
2525
"""
26-
rejected = False
27-
if isinstance(review, dict):
28-
rejected = bool(review.get("review_rejected", False))
2926
return Review(
3027
id=get(review, int, "review_id"),
3128
reviewer_id=get(review, int, "reviewer_id"),
3229
notes=get(review, str, "review_notes"),
33-
rejected=rejected,
30+
rejected=get(review, bool, "review_rejected"),
3431
type=ReviewType(get(review, str, "review_type")),
3532
)

tests/results/test_review.py

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)