Skip to content

Commit 690ed9a

Browse files
committed
review fixes
1 parent 45c84d4 commit 690ed9a

File tree

17 files changed

+148
-154
lines changed

17 files changed

+148
-154
lines changed

backend/src/ee/services/license/license-fns.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const getDefaultOnPremFeatures = (): TFeatureSet => ({
1717
environmentsUsed: 0,
1818
identityLimit: null,
1919
identitiesUsed: 0,
20-
dynamicSecret: false,
20+
dynamicSecret: true,
2121
secretVersioning: true,
2222
pitRecovery: false,
2323
ipAllowlisting: false,

docs/documentation/platform/dynamic-secrets/aws-elasticache.mdx

+3-3
Original file line numberDiff line numberDiff line change
@@ -114,12 +114,12 @@ The Infisical AWS ElastiCache dynamic secret allows you to generate AWS ElastiCa
114114
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
115115
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
116116

117-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
117+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
118118

119119
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
120120

121121
<Tip>
122-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
122+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
123123
</Tip>
124124

125125

@@ -131,7 +131,7 @@ The Infisical AWS ElastiCache dynamic secret allows you to generate AWS ElastiCa
131131

132132
## Audit or Revoke Leases
133133
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
134-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
134+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
135135

136136
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)
137137

docs/documentation/platform/dynamic-secrets/azure-entra-id.mdx

+4-4
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ Click on Add assignments. Search for the application name you created and select
123123

124124
</Step>
125125
<Step title="Click `Submit`">
126-
After submitting the form, you will see a dynamic secrets for each user created in the dashboard.
126+
After submitting the form, you will see a dynamic secret for each user created in the dashboard.
127127
</Step>
128128

129129
<Step title="Generate dynamic secrets">
@@ -134,12 +134,12 @@ Click on Add assignments. Search for the application name you created and select
134134
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
135135
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
136136

137-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
137+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
138138

139139
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
140140

141141
<Tip>
142-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
142+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
143143
</Tip>
144144

145145

@@ -151,7 +151,7 @@ Click on Add assignments. Search for the application name you created and select
151151

152152
## Audit or Revoke Leases
153153
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
154-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
154+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
155155

156156
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)
157157

docs/documentation/platform/dynamic-secrets/elastic-search.mdx

+3-3
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,12 @@ The Infisical Elasticsearch dynamic secret allows you to generate Elasticsearch
9797
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
9898
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
9999

100-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
100+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
101101

102102
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
103103

104104
<Tip>
105-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
105+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
106106
</Tip>
107107

108108

@@ -114,7 +114,7 @@ The Infisical Elasticsearch dynamic secret allows you to generate Elasticsearch
114114

115115
## Audit or Revoke Leases
116116
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
117-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
117+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
118118

119119
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)
120120

docs/documentation/platform/dynamic-secrets/gcp-iam.mdx

+14-14
Original file line numberDiff line numberDiff line change
@@ -97,36 +97,36 @@ The Infisical GCP IAM dynamic secret allows you to generate GCP service account
9797
</ParamField>
9898
</Step>
9999
<Step title="Click `Submit`">
100-
After submitting the form, you will see a dynamic secrets for each user created in the dashboard.
100+
After submitting the form, you will see a dynamic secret created in the dashboard.
101101
</Step>
102102

103103
<Step title="Generate dynamic secrets">
104-
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
105-
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
106-
Alternatively, you can initiate the creation of a new lease by selecting 'New Lease' from the dynamic secret lease list section.
104+
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
105+
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
106+
Alternatively, you can initiate the creation of a new lease by selecting 'New Lease' from the dynamic secret lease list section.
107107

108-
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
109-
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
108+
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
109+
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
110110

111-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
111+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
112112

113-
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
113+
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
114114

115-
<Tip>
116-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
117-
</Tip>
115+
<Tip>
116+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
117+
</Tip>
118118

119-
Once you click the `Submit` button, a new secret lease will be generated and the credentials from it will be shown to you.
119+
Once you click the `Submit` button, a new secret lease will be generated and the credentials from it will be shown to you.
120120

121-
![Dynamic Secret Lease](/images/platform/dynamic-secrets/dynamic-secret-gcp-iam-lease.png)
121+
![Dynamic Secret Lease](/images/platform/dynamic-secrets/dynamic-secret-gcp-iam-lease.png)
122122
</Step>
123123
</Steps>
124124

125125
## Audit or Revoke Leases
126126

127127
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
128128

129-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
129+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
130130

131131
![Lease Data](/images/platform/dynamic-secrets/lease-data.png)
132132

docs/documentation/platform/dynamic-secrets/ldap.mdx

+4-4
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,12 @@ The Infisical LDAP dynamic secret allows you to generate user credentials on dem
136136
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
137137
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
138138

139-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
139+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
140140

141141
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
142142

143143
<Tip>
144-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
144+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
145145
</Tip>
146146

147147

@@ -239,12 +239,12 @@ The Infisical LDAP dynamic secret allows you to generate user credentials on dem
239239
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
240240
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
241241
242-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
242+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
243243
244244
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
245245
246246
<Tip>
247-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
247+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
248248
</Tip>
249249
250250

docs/documentation/platform/dynamic-secrets/mongo-atlas.mdx

+8-8
Original file line numberDiff line numberDiff line change
@@ -68,17 +68,17 @@ Create a project scopped API Key with the required permission in your Mongo Atla
6868
- **Type**: Category of resource that this database user can access.
6969
</Step>
7070
<Step title="Click 'Submit'">
71-
After submitting the form, you will see a dynamic secret created in the dashboard.
71+
After submitting the form, you will see a dynamic secret created in the dashboard.
7272

7373
<Note>
74-
If this step fails, you may have to add the CA certficate.
74+
If this step fails, you may have to add the CA certficate.
7575
</Note>
7676

7777
![Dynamic Secret](../../../images/platform/dynamic-secrets/dynamic-secret.png)
7878
</Step>
7979
<Step title="Generate dynamic secrets">
80-
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
81-
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
80+
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
81+
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
8282
Alternatively, you can initiate the creation of a new lease by selecting 'New Lease' from the dynamic secret lease list section.
8383

8484
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
@@ -89,19 +89,19 @@ Create a project scopped API Key with the required permission in your Mongo Atla
8989
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
9090

9191
<Tip>
92-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
92+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
9393
</Tip>
9494

9595

96-
Once you click the `Submit` button, a new secret lease will be generated and the credentials for it will be shown to you.
96+
Once you click the `Submit` button, a new secret lease will be generated and the credentials for it will be shown to you.
9797

9898
![Provision Lease](/images/platform/dynamic-secrets/lease-values.png)
9999
</Step>
100100
</Steps>
101101

102102
## Audit or Revoke Leases
103-
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
104-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
103+
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
104+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
105105

106106
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)
107107

docs/documentation/platform/dynamic-secrets/mongo-db.mdx

+10-10
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Create a user with the required permission in your MongoDB instance. This user w
6262
Human-readable label that identifies a group of privileges assigned to a database user. This value can either be a built-in role or a custom role.
6363
- Enum: `atlasAdmin` `backup` `clusterMonitor` `dbAdmin` `dbAdminAnyDatabase` `enableSharding` `read` `readAnyDatabase` `readWrite` `readWriteAnyDatabase` `<a custom role name>`.
6464
</ParamField>
65-
65+
6666
<ParamField path="CA(SSL)" type="string">
6767
A CA may be required if your DB requires it for incoming connections.
6868
</ParamField>
@@ -71,39 +71,39 @@ Create a user with the required permission in your MongoDB instance. This user w
7171
</Step>
7272

7373
<Step title="Click `Submit`">
74-
After submitting the form, you will see a dynamic secret created in the dashboard.
74+
After submitting the form, you will see a dynamic secret created in the dashboard.
7575

7676
<Note>
77-
If this step fails, you may have to add the CA certificate.
77+
If this step fails, you may have to add the CA certificate.
7878
</Note>
7979

8080
</Step>
8181
<Step title="Generate dynamic secrets">
82-
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
83-
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
82+
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
83+
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
8484
Alternatively, you can initiate the creation of a new lease by selecting 'New Lease' from the dynamic secret lease list section.
8585

8686
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
8787
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-lease-empty.png)
8888

89-
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
89+
When generating these secrets, it's important to specify a Time-to-Live (TTL) duration. This will dictate how long the credentials are valid for.
9090

9191
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
9292

9393
<Tip>
94-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
94+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
9595
</Tip>
9696

9797

98-
Once you click the `Submit` button, a new secret lease will be generated and the credentials from it will be shown to you.
98+
Once you click the `Submit` button, a new secret lease will be generated and the credentials from it will be shown to you.
9999

100100
![Provision Lease](/images/platform/dynamic-secrets/lease-values.png)
101101
</Step>
102102
</Steps>
103103

104104
## Audit or Revoke Leases
105-
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
106-
This will allow you to see the expiration time of the lease or delete a lease before it's set time to live.
105+
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
106+
This will allow you to see the expiration time of the lease or delete a lease before its set time to live.
107107

108108
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)
109109

docs/documentation/platform/dynamic-secrets/mssql.mdx

+8-8
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Create a user with the required permission in your SQL instance. This user will
6262
<ParamField path="Database Name" type="string" required>
6363
Name of the database for which you want to create dynamic secrets
6464
</ParamField>
65-
65+
6666
<ParamField path="CA(SSL)" type="string">
6767
A CA may be required if your DB requires it for incoming connections. AWS RDS instances with default settings will requires a CA which can be downloaded [here](https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/UsingWithRDS.SSL.html#UsingWithRDS.SSL.CertificatesAllRegions).
6868
</ParamField>
@@ -76,17 +76,17 @@ Create a user with the required permission in your SQL instance. This user will
7676
![Modify SQL Statements Modal](../../../images/platform/dynamic-secrets/modify-sql-statements-mssql.png)
7777
</Step>
7878
<Step title="Click 'Submit'">
79-
After submitting the form, you will see a dynamic secret created in the dashboard.
79+
After submitting the form, you will see a dynamic secret created in the dashboard.
8080

8181
<Note>
82-
If this step fails, you may have to add the CA certficate.
82+
If this step fails, you may have to add the CA certficate.
8383
</Note>
8484

8585
![Dynamic Secret](../../../images/platform/dynamic-secrets/dynamic-secret.png)
8686
</Step>
8787
<Step title="Generate dynamic secrets">
88-
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
89-
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
88+
Once you've successfully configured the dynamic secret, you're ready to generate on-demand credentials.
89+
To do this, simply click on the 'Generate' button which appears when hovering over the dynamic secret item.
9090
Alternatively, you can initiate the creation of a new lease by selecting 'New Lease' from the dynamic secret lease list section.
9191

9292
![Dynamic Secret](/images/platform/dynamic-secrets/dynamic-secret-generate.png)
@@ -97,18 +97,18 @@ Create a user with the required permission in your SQL instance. This user will
9797
![Provision Lease](/images/platform/dynamic-secrets/provision-lease.png)
9898

9999
<Tip>
100-
Ensure that the TTL for the lease fall within the maximum TTL defined when configuring the dynamic secret.
100+
Ensure that the TTL for the lease falls within the maximum TTL defined when configuring the dynamic secret.
101101
</Tip>
102102

103103

104-
Once you click the `Submit` button, a new secret lease will be generated and the credentials for it will be shown to you.
104+
Once you click the `Submit` button, a new secret lease will be generated and the credentials for it will be shown to you.
105105

106106
![Provision Lease](/images/platform/dynamic-secrets/lease-values.png)
107107
</Step>
108108
</Steps>
109109

110110
## Audit or Revoke Leases
111-
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
111+
Once you have created one or more leases, you will be able to access them by clicking on the respective dynamic secret item on the dashboard.
112112
This will allow you to see the expiration time of the lease or delete the lease before it's set time to live.
113113

114114
![Provision Lease](/images/platform/dynamic-secrets/lease-data.png)

0 commit comments

Comments
 (0)