Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect domain override in login #1106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quinton11
Copy link
Contributor

Description 📣

Closes #939
After the current logged in user is checked in the login Cmd,

  • config.INFISICAL_URL is the current logged in user's domain url
  • config.INFISICAL_URL_MANUAL_OVERRIDE is the value of the manual override set from --domain or the INFISICAL_API_URL env variable
  • We check if the domain flag was set or the env variable exists, if yes, we respect the manual override
  • If not we assume config.INFISICAL_URL is the default api url then prompt for a domain override ( necessary? )

@quinton11
Copy link
Contributor Author

@maidul98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

infisical init should respect --domain option and INFISICAL_APP_URL
2 participants