fix: repair BU position larger than 1cm GAWR-5443

Author: ArneD

src/BuildingRegistry/Building/BuildingUnit.cs

@@ -499,11 +499,17 @@ public void RepairPosition(BuildingGeometry buildingGeometry)
 
             if (correctedGeometry is not null)
             {
-                Apply(new BuildingUnitPositionWasCorrected(
-                    _buildingPersistentLocalId,
-                    BuildingUnitPersistentLocalId,
-                    BuildingUnitPositionGeometryMethod.DerivedFromObject,
-                    correctedGeometry));
+                var currentPosition = buildingGeometry.GetGeometry(BuildingUnitPosition.Geometry);
+                var newPosition = buildingGeometry.GetGeometry(correctedGeometry);
+
+                if (currentPosition.Distance(newPosition) > 0.01)
+                {
+                    Apply(new BuildingUnitPositionWasCorrected(
+                        _buildingPersistentLocalId,
+                        BuildingUnitPersistentLocalId,
+                        BuildingUnitPositionGeometryMethod.DerivedFromObject,
+                        correctedGeometry));
+                }
             }
         }
 

src/BuildingRegistry/Building/ValueObjects/BuildingGeometry.cs

@@ -43,6 +43,9 @@ private ExtendedWkbGeometry CleanUpGeometryCollection(ExtendedWkbGeometry geomet
         public ExtendedWkbGeometry Center =>
             ExtendedWkbGeometry.CreateEWkb(_wkbReader.Read(Geometry).CentroidWithinArea().AsBinary())!;
 
+        public Geometry GetGeometry() => _wkbReader.Read(Geometry);
+        public Geometry GetGeometry(ExtendedWkbGeometry geometry) => _wkbReader.Read(geometry);
+
         protected override IEnumerable<object> Reflect()
         {
             yield return Geometry;

test/BuildingRegistry.Tests/AggregateTests/WhenRepairingBuilding/GivenBuildingExists.cs

@@ -11,6 +11,7 @@ namespace BuildingRegistry.Tests.AggregateTests.WhenRepairingBuilding
     using BuildingRegistry.Legacy;
     using Extensions;
     using Fixtures;
+    using NetTopologySuite.Geometries;
     using Xunit;
     using Xunit.Abstractions;
     using BuildingGeometry = BuildingRegistry.Legacy.BuildingGeometry;
@@ -23,6 +24,7 @@ namespace BuildingRegistry.Tests.AggregateTests.WhenRepairingBuilding
     using BuildingUnitPositionGeometryMethod = BuildingRegistry.Legacy.BuildingUnitPositionGeometryMethod;
     using BuildingUnitStatus = BuildingRegistry.Legacy.BuildingUnitStatus;
     using ExtendedWkbGeometry = BuildingRegistry.Legacy.ExtendedWkbGeometry;
+    using GeometryFactory = BuildingRegistry.GeometryFactory;
 
     public class GivenBuildingExists : BuildingRegistryTest
     {
@@ -63,5 +65,38 @@ public void WithUnitsDerivedButNotInCenter_ThenBuildingAndUnitsWereRepaired()
                         BuildingRegistry.Building.BuildingUnitPositionGeometryMethod.DerivedFromObject,
                         new BuildingRegistry.Building.BuildingGeometry(BuildingRegistry.Building.ExtendedWkbGeometry.CreateEWkb(migrated.ExtendedWkbGeometry.ToByteArray()), BuildingGeometryMethod.MeasuredByGrb).Center))));
         }
+
+        [Fact]
+        public void WithUnitsDerivedButCloseToCenter_ThenBuildingAndUnitsWereRepaired()
+        {
+            var command = Fixture.Create<RepairBuilding>();
+
+            var migrated = new BuildingWasMigratedBuilder(Fixture)
+                .WithBuildingStatus(BuildingStatus.Realized)
+                .Build();
+
+            var reader = WKBReaderFactory.Create();
+            reader.HandleSRID = true;
+
+            var centroid = reader.Read(migrated.ExtendedWkbGeometry.ToByteArray()).Centroid;
+            var closePosition = new Point(centroid.X - 0.001, centroid.Y + 0.001) { SRID = GeometryFactory.CreateGeometryFactory().SRID };
+
+            migrated.BuildingUnits.Add(new BuildingWasMigrated.BuildingUnit(new BuildingUnit(
+                new BuildingUnitId(Fixture.Create<Guid>()),
+                new PersistentLocalId(Fixture.Create<int>()),
+                BuildingUnitFunction.Unknown,
+                BuildingUnitStatus.Realized,
+                [],
+                new BuildingUnitPosition(ExtendedWkbGeometry.CreateEWkb(closePosition.AsBinary()), BuildingUnitPositionGeometryMethod.DerivedFromObject),
+                new BuildingGeometry(new ExtendedWkbGeometry(migrated.ExtendedWkbGeometry.ToByteArray()), BuildingRegistry.Legacy.BuildingGeometryMethod.MeasuredByGrb),
+                false)));
+
+            Assert(new Scenario()
+                .Given(
+                    new BuildingStreamId(Fixture.Create<BuildingPersistentLocalId>())!,
+                    migrated)
+                .When(command)
+                .ThenNone());
+        }
     }
 }