Parcel Registry: Data Issues concerning removed parcels #4
Description
Concerning issue(s): GRAR-1475
Data CRAB
The third record in the history table shows eindbewerking = 4 which is a delete.
Then the fourth shows beginbewerking = 1 which is an insert, so after delete there is an insert.
Note: there is no insert at the start, which is because the capakey format changed, the original capakey had an insert record.
Events
At StreamVersion 7 event ParcelWasRemoved is applied. But there are CRAB events applied afterwards. Which should not be possible. However, this was only fixed since Informatievlaanderen/parcel-registry@e4c2a5b#diff-597a3c9bce8b7cf275bb4dac462812af52bfa3aca52a7e7ce4cd1613dd2c8e5eR34-R35
On 31/08/2020 fix (1475) was applied. (Informatievlaanderen/parcel-registry@b1264a7)
Problem
Now a new record for this parcel comes in. But the IsRemoved check makes it crash.
Solution
First, we need an answer if the behavior of reinserting a removed parcel is valid.
If so, we'll need to change our code to allow reviving parcels.
After discussion it is possible, however very unlikely, that a parcel is restored.
We'll need to change our code so.
- If a
removefrom CRAB is followed by aninsertwe recover the parcel. - We need to create a new event that encapsulates this.
- Update projections / sync projections to handle this new event.
- We do NOT reapply linked addresses, will have to come via CRAB.
- Since some parcels should've been restored already, we'll need to create a fix command and send it to the import api for the related parcels.