Merge pull request #50 from appleboy/patch

popcornylu · web-flow · commit 018fcd95b950 · 2022-06-17T23:03:36.000+08:00
chore(manager): also check err is nil or not
diff --git a/internal/core/manager.go b/internal/core/manager.go
@@ -41,10 +41,8 @@ func NewArtifactManager(config ArtConfig) (*ArtifactManager, error) {
 	}
 
 	finfo, err := os.Stat(baseDir)
-	if err == nil {
-		if !finfo.IsDir() {
-			return nil, errors.New(baseDir + " is not a directory")
-		}
+	if err != nil || !finfo.IsDir() {
+		return nil, errors.New(baseDir + " is not a directory")
 	}
 
 	// init the metadata path

Original file line number	Diff line number	Diff line change
`@@ -41,10 +41,8 @@ func NewArtifactManager(config ArtConfig) (*ArtifactManager, error) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`finfo, err := os.Stat(baseDir)`
`44`		`- if err == nil {`
`45`		`- if !finfo.IsDir() {`
`46`		`- return nil, errors.New(baseDir + " is not a directory")`
`47`		`- }`
	`44`	`+ if err != nil \|\| !finfo.IsDir() {`
	`45`	`+ return nil, errors.New(baseDir + " is not a directory")`
`48`	`46`	`}`
`49`	`47`
`50`	`48`	`// init the metadata path`