Skip to content

Commit 88457a5

Browse files
authored
Merge pull request #45 from InputActions/scripting-delay-throw
scripting/main: make delay() throw instead of returning rejected promise
2 parents 62a393e + 8519856 commit 88457a5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/libinputactions/scripting/modules/main/MainModule.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ MainModule::MainModule(ScriptingEngine &engine)
3030

3131
QJSValue MainModule::delay(double duration)
3232
{
33-
auto promise = g_scriptingEngine->newPromise();
3433
if (duration < 1 || duration > INT32_MAX) {
35-
promise.reject(m_engine.ensureEngine().newErrorObject(QJSValue::RangeError, QString("Value %1 is out of range.").arg(QString::number(duration))));
36-
return promise.promise();
34+
m_engine.ensureEngine().throwError(QJSValue::RangeError, QString("Value %1 is out of range.").arg(QString::number(duration)));
35+
return {};
3736
}
3837

38+
auto promise = g_scriptingEngine->newPromise();
3939
QTimer::singleShot(std::floor(duration), Qt::PreciseTimer, this, [promise]() {
4040
promise.fulfill();
4141
});

0 commit comments

Comments
 (0)