Improving ODF average feature #121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the ODF average tool developed by Thomas Durantel. The three major modifications are:
1- Make the tool work with ODF which don't integrate to 1 over the sphere (notably fiber-ODF from CSD or MSMT-CSD) by adding a normalization step and a step to cancel the normalization at the end
2- Perform averaging computations only when necessary: if all inputs are null vectors, we simply output a null vector, and if only 1 input is not null, we simply output the latter
3- Use of spherical design points instead of a grid on the sphere for getting an ODF in sampled form. Spherical designs enable to compute sums on the unit sphere instead of integrals without any loss of information
I added many comments to explain what is being done.