Skip to content

Commands using Selections now require Confirm label #3077

Open
@Zeranny

Description

@Zeranny

Server Implementation

Paper

Server Version

1.20.4

Describe the bug

Changes in #3052 now require commands using selections to include @Confirm(Confirm.Processor.REGION). Not having this gives a pretty unfriendly error:

image

Previously you would just get the regular informative error:

image

I have tested adding the annotation to one command and it doesn't appear to cause issues with regular WorldEdit, so the change doesn't cause any compatibility issues.

To Reproduce

  1. Create a command which takes a Selection
  2. Do not add the Confirm annotation
  3. Run the command ingame without an active selection
  4. IllegalStateException error

Expected behaviour

Commands expecting a selection which do not recieve one should error instructively as before:
image

Effectively, when no @Confirm(...) is present for the region, Confirm.Processor.REGION should be the default.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

https://athion.net/ISPaster/paste/view/d8e209464d4e4bcd85aec7766117481f

Fawe Version

FastAsyncWorldEdit-Bukkit-2.12.4-SNAPSHOT-1020

Checklist

Anything else?

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Requires TestingThis is a new issue which needs to be approved before labeled with "bug"

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions