fix: ObjectDisposedException in GetExceptionResult

Author: ascott18

CHANGELOG.md

@@ -5,6 +5,11 @@
 - Added a `reset` method to all [API caller objects](https://intellitect.github.io/Coalesce/stacks/vue/layers/api-clients.html#api-callers). This method resets all stateful fields on the object to default values.
 - Template: Added username/password auth option (aka individual user accounts, aka local accounts)
 
+## Fixes
+
+- Fix an ObjectDisposedException from `StandardBehaviors.GetExceptionResult` when using an `IDbContextFactory` in an `Execute[Save|Delete]Async` implementation.
+
+
 # 5.1.0
 
 ## Features

src/IntelliTect.Coalesce.Tests/Tests/Api/Behaviors/SqlServerExceptionResultTests.cs

@@ -241,6 +241,25 @@ public void UniqueIndexConflict_UnknownIndex()
         Assert.Null(result);
     }
 
+    [Fact]
+    public void DbContextIsDisposed()
+    {
+        Db.Add(new Product { UniqueId1 = "qwerty" });
+
+        var exception = CreateException(
+            "Cannot insert duplicate key row in object 'dbo.Product' with unique index 'IX_Product_UniqueId1'. " +
+            "The duplicate key value is (qwerty)");
+
+        // The context might dispose before GetExceptionResult is reached if the user is using an IDbContextFactory
+        // with a `using` inside their ExecuteSaveAsync implementation.
+        Db.Dispose();
+
+        var result = Behaviors<Product>()
+            .GetExceptionResult(exception, new TestSparseDto<Product>() { ChangedProperties = { "UniqueId1" } });
+
+        result.AssertError("A different item with ID1 'qwerty' already exists.");
+    }
+
     private DbUpdateException CreateException(string error)
     {
         return new DbUpdateException("", CreateSqlException(547, error), Db.ChangeTracker.Entries().ToList());

src/IntelliTect.Coalesce/Api/Behaviors/StandardBehaviors`1.cs

@@ -539,9 +539,9 @@ public virtual void AfterDelete(ref T item, ref IncludeTree? includeTree) { }
                 return null;
             }
 
-            DbContext? dbContext = dbUpdateException.Entries.FirstOrDefault()?.Context;
+            IModel? model = dbUpdateException.Entries.FirstOrDefault()?.Metadata.Model;
 
-            if (dbUpdateException.InnerException is not DbException dbException || dbContext is null)
+            if (dbUpdateException.InnerException is not DbException dbException || model is null)
             {
                 return null;
             }
@@ -560,7 +560,7 @@ public virtual void AfterDelete(ref T item, ref IncludeTree? includeTree) { }
                 string table = match.Groups["table"].Value;
                 string column = match.Groups["column"].Value;
 
-                var conflictedTable = dbContext.Model
+                var conflictedTable = model
                     .GetEntityTypes()
                     .Where(t =>
                         t.GetSchemaQualifiedTableName() == table ||
@@ -629,7 +629,7 @@ dependentEntity is not null &&
                 string tableName = match.Groups["table"].Value;
                 string keyValue = match.Groups["keyValue"].Value;
 
-                var table = dbContext.Model
+                var table = model
                     .GetEntityTypes()
                     .FirstOrDefault(t =>
                         t.GetSchemaQualifiedTableName() == tableName ||