fix: handle required constraints on internal use properties.

Author: ascott18

CHANGELOG.md

@@ -5,6 +5,7 @@
 - Fix `c-admin-editor-page` briefly showing editors while the item is initially loading.
 - `c-input` no longer wraps default slot fallback content in a superfluous div.
 - `c-input` no longer attempts to delegate shared-key one-to-one properties to `c-select`, a scenario that is not possible to select values for.
+- DTOs no longer generate MapToNew methods with unsatisfied `required` constraints.
 
 # 6.0.1
 - `createAspNetCoreHmrPlugin` now displays NPM package mismatches with the standard vite overlay instead of a custom overlay.

src/IntelliTect.Coalesce.Tests/TargetClasses/TestDbContext/RequiredInternalUseModel.cs

@@ -0,0 +1,13 @@
+using IntelliTect.Coalesce.DataAnnotations;
+
+namespace IntelliTect.Coalesce.Tests.TargetClasses.TestDbContext;
+
+[Create(SecurityPermissionLevels.DenyAll)]
+[Edit(SecurityPermissionLevels.DenyAll)]
+public class RequiredInternalUseModel
+{
+    public int Id { get; set; }
+
+    [InternalUse]
+    public required string InternalRequiredProp { get; init; }
+}

src/IntelliTect.Coalesce.Tests/TargetClasses/TestDbContext/TestDbContext.cs

@@ -19,6 +19,7 @@ public class AppDbContext : DbContext
     public DbSet<ComplexModelDependent> ComplexModelDependents { get; set; }
     public DbSet<ReadOnlyEntityUsedAsMethodInput> ReadOnlyEntityUsedAsMethodInputs { get; set; }
     public DbSet<RequiredAndInitModel> RequiredAndInitModels { get; set; }
+    public DbSet<RequiredInternalUseModel> RequiredInternalUseModels { get; set; }
     public DbSet<Test> Tests { get; set; }
 
     public DbSet<AbstractModel> AbstractModels { get; set; }

src/IntelliTect.Coalesce/TypeDefinition/MethodViewModel.cs

@@ -340,15 +340,15 @@ public ConstructorUsage DtoMapToNewConstructorUsage
 #if NET7_0_OR_GREATER
             if (!this.HasAttribute<System.Diagnostics.CodeAnalysis.SetsRequiredMembersAttribute>())
             {
-                foreach (var requiredProp in Parent.ClientProperties.Where(p => p.HasRequiredKeyword))
+                foreach (var requiredProp in Parent.Properties.Where(p => p.HasRequiredKeyword))
                 {
                     if (!incomingProperties.ContainsKey(requiredProp.Name))
                     {
                         return new ConstructorUsage
                         {
                             IsAcceptable = false,
                             Reason = $"Required property `{requiredProp.Name}` is not accepted as an input, " +
-                                $"so Coalesce cannnot satisfy its `required` constraint. Adding [SetsRequiredMembers] will suppress this."
+                                $"so Coalesce cannot satisfy its `required` constraint. Adding [SetsRequiredMembers] will suppress this."
                         };
                     }
                 }