menu.c: Remove RWLIST_UNLOCK call when list is already unlocked.

InterLinked1 · InterLinked1 · commit 3bfd01672065 · 2026-03-06T10:17:44.000-05:00
There was one path where we unlocked the menus list, but the listed
was already unlocked, likely a vestige of when we kept the menus
listed locked all the time while the menu was running, as opposed to
just when we needed to access its options.

LBBS-141 #close
diff --git a/bbs/menu.c b/bbs/menu.c
@@ -615,7 +615,6 @@ static int bbs_menu_run(struct bbs_node *node, const char *menuname, const char
 			bbs_node_buffer(node);
 			res = bbs_node_read_line(node, SEC_MS(30), menusequence, sizeof(menusequence) - 1);
 			if (res <= 0) {
-				RWLIST_UNLOCK(&menus);
 				return opt;
 			}
 			menusequence[res] = '\0'; /* Null terminate */

Original file line number	Diff line number	Diff line change
`@@ -615,7 +615,6 @@ static int bbs_menu_run(struct bbs_node node, const char menuname, const char`
`615`	`615`	`bbs_node_buffer(node);`
`616`	`616`	`res = bbs_node_read_line(node, SEC_MS(30), menusequence, sizeof(menusequence) - 1);`
`617`	`617`	`if (res <= 0) {`
`618`		`- RWLIST_UNLOCK(&menus);`
`619`	`618`	`return opt;`
`620`	`619`	`}`
`621`	`620`	`menusequence[res] = '\0'; /* Null terminate */`