Commit f00dedd
fix: address code review findings — cache resolver, fix misleading descriptions
Critical:
- C1: Cache AgentInterfaceResolver.ScanInterfaces() to avoid full assembly scan on every SendToAgent call
- C2: Fix misleading CleanLogsAsync description (it reads logs, doesn't clean)
Important:
- I1: Fix DeployAsync description to not claim rebuild capability (TODO stub)
- I3: Remove deploy-verify job from OnActivateAsync (only schedule from DeployAsync)
- I4: Add Aspire to error message's available agents list
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 0d2f286 commit f00dedd
4 files changed
Lines changed: 7 additions & 9 deletions
File tree
- src
- Agents
- Infrastructure
- Orchestration
- Core/Extensions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
| 31 | + | |
36 | 32 | | |
37 | 33 | | |
38 | 34 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
| 51 | + | |
50 | 52 | | |
51 | | - | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
0 commit comments