fix: call form request rules method with laravel container (#34)

Author: patrickhoogkamer

phpstan-baseline.neon

@@ -114,12 +114,6 @@ parameters:
 			count: 1
 			path: src/Generator/Mapping/Schema.php
 
-		-
-			message: '#^Method Intermax\\LaravelOpenApi\\Generator\\OperationCreator\:\:create\(\) has parameter \$responses with no value type specified in iterable type cebe\\openapi\\spec\\Responses\.$#'
-			identifier: missingType.iterableValue
-			count: 1
-			path: src/Generator/OperationCreator.php
-
 		-
 			message: '#^PHPDoc tag @param for parameter \$responses with type \(cebe\\openapi\\spec\\Responses&iterable\<cebe\\openapi\\spec\\Response\>\)\|null is not subtype of native type cebe\\openapi\\spec\\Responses\.$#'
 			identifier: parameter.phpDocType

src/Generator/RequestBodyCreator.php

@@ -5,14 +5,19 @@
 use cebe\openapi\spec\RequestBody;
 use cebe\openapi\spec\Schema;
 use Illuminate\Contracts\Config\Repository;
+use Illuminate\Foundation\Application;
 use Illuminate\Foundation\Http\FormRequest;
 use Illuminate\Validation\Rule;
 use Intermax\LaravelOpenApi\Contracts\HasQueryParameters;
 use UnhandledMatchError;
 
 class RequestBodyCreator
 {
-    public function __construct(private readonly Repository $config, private ComponentManager $componentManager) {}
+    public function __construct(
+        private readonly Repository $config,
+        private ComponentManager $componentManager,
+        private Application $app,
+    ) {}
 
     public function create(FormRequest $request, ?string $entityName = null): ?RequestBody
     {
@@ -159,7 +164,7 @@ protected function rulesWithoutQueryParameters(FormRequest $request): array
         assert(method_exists($request, 'rules'));
 
         return array_filter(
-            array: $request->rules(),
+            array: $this->app->call($request->rules(...)), // @phpstan-ignore-line
             callback: fn ($name) => ! in_array($name, $queryParameters),
             mode: ARRAY_FILTER_USE_KEY
         );

tests/QueryParameters/Utilities/Dummy.php

@@ -0,0 +1,7 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Intermax\LaravelOpenApi\Tests\QueryParameters\Utilities;
+
+class Dummy {}

tests/QueryParameters/Utilities/ThingCollectionRequest.php

@@ -29,7 +29,7 @@ public function queryParameters(): array
         ];
     }
 
-    public function rules(): array
+    public function rules(Dummy $dummy): array
     {
         return ['filter.test' => 'string'];
     }

tests/RequestBody/RequestBodyCreatorTest.php

@@ -19,4 +19,15 @@ public function it_omits_query_parameters_from_request_body()
 
         $this->assertNull($output);
     }
+
+    #[Test]
+    public function it_does_not_fail_with_exception_when_rules_method_requires_additional_arguments()
+    {
+        /** @var RequestBodyCreator $creator */
+        $creator = $this->app->make(RequestBodyCreator::class);
+
+        $output = $creator->create($this->app->make(ThingCollectionRequest::class));
+
+        $this->assertNull($output);
+    }
 }