Drop GHC support for <9.6.7 #534
Open
+165
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/drop-support-upto-ghc967
branch
from
2f11df5 to
629a312
Compare
aniketd
force-pushed
the
aniketd/drop-support-upto-ghc967
branch
from
629a312 to
017b916
Compare
aniketd
commented
May 20, 2025
| index-state: cardano-haskell-packages 2025-05-14T07:44:24Z | ||
| index-state: cardano-haskell-packages 2025-04-08T17:22:48Z |
There was a problem hiding this comment.
This change was necessary in order to be able to reuse the flake inputs that do not cause a problem on MacOS.
There was a problem hiding this comment.
You should not be downgrading index-state
aniketd
force-pushed
the
aniketd/drop-support-upto-ghc967
branch
from
017b916 to
0b06f22
Compare
aniketd
force-pushed
the
aniketd/drop-support-upto-ghc967
branch
from
0b06f22 to
f3a4da3
Compare
lehins
requested changes
May 22, 2025
| index-state: cardano-haskell-packages 2025-05-14T07:44:24Z | ||
| index-state: cardano-haskell-packages 2025-04-08T17:22:48Z |
There was a problem hiding this comment.
You should not be downgrading index-state
neilmayhew
reviewed
May 22, 2025
| @@ -207,7 +201,7 @@ | |||
| }; | |||
| in | |||
| mkDevShells cabalProject | |||
| # Additional shells for every GHC version supported by haskell.nix, eg. `nix develop .#ghc8107` | |||
| # Additional shells for every GHC version supported by haskell.nix, eg. `nix develop .#ghc8122` | |||
There was a problem hiding this comment.
Suggested change
| # Additional shells for every GHC version supported by haskell.nix, eg. `nix develop .#ghc8122` | |
| # Additional shells for every GHC version supported by haskell.nix, eg. `nix develop .#ghc9122` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #530
Checklist
New tests are added if needed and existing tests are updatedAll visible changes are prepended to the latest section of aCHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)