[FR] - Input cost models validation

[carbolymer]

Internal/External
Internal

Area
Other

Context
When providing plutus cost models as an input to cardano-cli:

• as a map
  • excess parameters are ignored, only existing parameters are checked.
  • If the existing parameters are missing, the parsing fails and the error is reported.
• as a list
  • lists longer than expected are consumed up to the number of existing parameters - excess parameters are ignored.
  • If the list of cost model parameters is too short, the missing parameters are defaulted to maxBound :: Int64 and no error is reported.

Description
When an user provides a cost model containing too many or not enough parameters, cardano-cli should fail with an appropriate message.

Additional info
The original issue:

• PlutusV3 cost model update with 299 items stripped to 251 #924 (comment)

The v2 cost models included in Alonzo Genesis validation and conversion was implemented in

• Fix reading of Plutus V2 cost models with different lengths in AlonzoGenesis in different eras cardano-api#564 - parts of the logic potentially can be reused for this as well.

New strict validations in ledger for cost models in geneses:

• Fix JSON parsing for CostModels cardano-ledger#5241

Relevant changes in cardano-api (part of node-10.6 release):

• Disable Alonzo Genesis cost models validation, since it is done by ledger now cardano-api#958

Warning

Needs clarification: Which cost models should we cover with this validation? V1? V2? V3?

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

[smelc]

Function readCostModels in Read.hs is a good candidate for performing this validation.

[CarlosLopezDeLara]

Needs clarification: Which cost models should we cover with this validation? V1? V2? V3?

A proposal may attempt change any of the cost models: V1, V2 or V3. So would be desirable to make this validation for the three versions.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.