Fix lovelaceToAda function

The old version of this function had type `Micro -> Ada`, but that
type allowed its use in `lovelaceToAda . MkFixed . fromIntegral` AND
as `lovelaceToAda . fromIntegral` with the former giving INCORRECT
results.
By switching the type to `Integer -> Ada` it is no longer possible
to use this function incorrectly.

Related: #2031

Author: erikd

cardano-db/src/Cardano/Db/Statement/Function/Query.hs

@@ -12,7 +12,6 @@
 module Cardano.Db.Statement.Function.Query where
 
 import Cardano.Prelude (HasCallStack, Proxy (..), Word64, listToMaybe)
-import Data.Fixed (Fixed (..))
 import Data.Functor.Contravariant (Contravariant (..))
 import qualified Data.List.NonEmpty as NE
 import qualified Data.Text as Text
@@ -265,5 +264,5 @@ adaSumDecoder :: HsqlD.Row Ada
 adaSumDecoder = do
   amount <- HsqlD.column (HsqlD.nullable HsqlD.int8)
   case amount of
-    Just value -> pure $ lovelaceToAda (MkFixed $ fromIntegral value)
+    Just value -> pure $ lovelaceToAda (fromIntegral value)
     Nothing -> pure $ Ada 0

cardano-db/src/Cardano/Db/Types.hs

@@ -532,16 +532,16 @@ word128Encoder = fromInteger . toInteger >$< HsqlE.numeric
 word128Decoder :: HsqlD.Value Word128
 word128Decoder = fromInteger . fromIntegral . coefficient <$> HsqlD.numeric
 
-lovelaceToAda :: Micro -> Ada
+lovelaceToAda :: Integer -> Ada
 lovelaceToAda ll =
-  Ada (ll / 1000000)
+  Ada (fromIntegral ll / 1000000)
 
 renderAda :: Ada -> Text
 renderAda (Ada a) = Text.pack (show a)
 
 scientificToAda :: Scientific -> Ada
 scientificToAda s =
-  word64ToAda $ floor (s * 1000000)
+  lovelaceToAda $ floor (s * 1000000)
 
 word64ToAda :: Word64 -> Ada
 word64ToAda w =