Add tests to check equivalence of DecCBORinstances via cddl and Huddle

Author: teodanciu

eras/allegra/impl/test/Test/Cardano/Ledger/Allegra/Binary/CddlSpec.hs

@@ -9,6 +9,7 @@ import Test.Cardano.Ledger.Allegra.Binary.Cddl (readAllegraCddlFiles)
 import Test.Cardano.Ledger.Allegra.CDDL (allegraCDDL)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
@@ -27,6 +28,10 @@ spec =
       cddlRoundTripCborSpec @(Script AllegraEra) v "native_script"
       cddlRoundTripAnnCborSpec @(TxAuxData AllegraEra) v "auxiliary_data"
       cddlRoundTripCborSpec @(TxAuxData AllegraEra) v "auxiliary_data"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(TxBody AllegraEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(Script AllegraEra) v "native_script"
+        cddlDecoderEquivalenceSpec @(TxAuxData AllegraEra) v "auxiliary_data"
 
     describe "Huddle" $ specWithHuddle allegraCDDL 100 $ do
       huddleRoundTripCborSpec @(Value AllegraEra) v "coin"

eras/alonzo/impl/test/Test/Cardano/Ledger/Alonzo/Binary/CddlSpec.hs

@@ -13,10 +13,12 @@ import Test.Cardano.Ledger.Alonzo.Binary.Cddl (readAlonzoCddlFiles)
 import Test.Cardano.Ledger.Alonzo.CDDL (alonzoCDDL)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
 import Test.Cardano.Ledger.Binary.Cuddle (
+  huddleDecoderEquivalenceSpec,
   huddleRoundTripAnnCborSpec,
   huddleRoundTripCborSpec,
   specWithHuddle,
@@ -46,6 +48,14 @@ spec =
       cddlRoundTripAnnCborSpec @(Tx AlonzoEra) v "transaction"
       cddlRoundTripCborSpec @(Tx AlonzoEra) v "transaction"
       cddlRoundTripCborSpec @CostModels v "cost_models"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(TxBody AlonzoEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(TxAuxData AlonzoEra) v "auxiliary_data"
+        cddlDecoderEquivalenceSpec @(Timelock AlonzoEra) v "native_script"
+        cddlDecoderEquivalenceSpec @(Data AlonzoEra) v "plutus_data"
+        cddlDecoderEquivalenceSpec @(AlonzoTxWits AlonzoEra) v "transaction_witness_set"
+        cddlDecoderEquivalenceSpec @(Redeemers AlonzoEra) v "[* redeemer]"
+        cddlDecoderEquivalenceSpec @(Tx AlonzoEra) v "transaction"
     describe "Huddle" $ specWithHuddle alonzoCDDL 100 $ do
       huddleRoundTripCborSpec @(Value AlonzoEra) v "coin"
       huddleRoundTripAnnCborSpec @(TxBody AlonzoEra) v "transaction_body"
@@ -65,3 +75,11 @@ spec =
       huddleRoundTripAnnCborSpec @(Tx AlonzoEra) v "transaction"
       huddleRoundTripCborSpec @(Tx AlonzoEra) v "transaction"
       huddleRoundTripCborSpec @CostModels v "cost_models"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        huddleDecoderEquivalenceSpec @(TxBody AlonzoEra) v "transaction_body"
+        huddleDecoderEquivalenceSpec @(TxAuxData AlonzoEra) v "auxiliary_data"
+        huddleDecoderEquivalenceSpec @(Timelock AlonzoEra) v "native_script"
+        huddleDecoderEquivalenceSpec @(Data AlonzoEra) v "plutus_data"
+        huddleDecoderEquivalenceSpec @(AlonzoTxWits AlonzoEra) v "transaction_witness_set"
+        huddleDecoderEquivalenceSpec @(Redeemers AlonzoEra) v "redeemers"
+        huddleDecoderEquivalenceSpec @(Tx AlonzoEra) v "transaction"

eras/babbage/impl/test/Test/Cardano/Ledger/Babbage/Binary/CddlSpec.hs

@@ -13,10 +13,12 @@ import Test.Cardano.Ledger.Babbage.Binary.Cddl (readBabbageCddlFiles)
 import Test.Cardano.Ledger.Babbage.CDDL (babbageCDDL)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
 import Test.Cardano.Ledger.Binary.Cuddle (
+  huddleDecoderEquivalenceSpec,
   huddleRoundTripAnnCborSpec,
   huddleRoundTripCborSpec,
   specWithHuddle,
@@ -49,6 +51,15 @@ spec =
       cddlRoundTripCborSpec @(Redeemers BabbageEra) v "redeemers"
       cddlRoundTripAnnCborSpec @(Tx BabbageEra) v "transaction"
       cddlRoundTripCborSpec @(Tx BabbageEra) v "transaction"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(TxBody BabbageEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(TxAuxData BabbageEra) v "auxiliary_data"
+        cddlDecoderEquivalenceSpec @(Timelock BabbageEra) v "native_script"
+        cddlDecoderEquivalenceSpec @(Data BabbageEra) v "plutus_data"
+        cddlDecoderEquivalenceSpec @(Script BabbageEra) v "script"
+        cddlDecoderEquivalenceSpec @(TxWits BabbageEra) v "transaction_witness_set"
+        cddlDecoderEquivalenceSpec @(Redeemers BabbageEra) v "redeemers"
+        cddlDecoderEquivalenceSpec @(Tx BabbageEra) v "transaction"
     describe "Huddle" $ specWithHuddle babbageCDDL 100 $ do
       huddleRoundTripCborSpec @(Value BabbageEra) v "coin"
       huddleRoundTripAnnCborSpec @(TxBody BabbageEra) v "transaction_body"
@@ -71,3 +82,12 @@ spec =
       huddleRoundTripCborSpec @(Redeemers BabbageEra) v "redeemers"
       huddleRoundTripAnnCborSpec @(Tx BabbageEra) v "transaction"
       huddleRoundTripCborSpec @(Tx BabbageEra) v "transaction"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        huddleDecoderEquivalenceSpec @(TxBody BabbageEra) v "transaction_body"
+        huddleDecoderEquivalenceSpec @(TxAuxData BabbageEra) v "auxiliary_data"
+        huddleDecoderEquivalenceSpec @(Timelock BabbageEra) v "native_script"
+        huddleDecoderEquivalenceSpec @(Data BabbageEra) v "plutus_data"
+        huddleDecoderEquivalenceSpec @(Script BabbageEra) v "script"
+        huddleDecoderEquivalenceSpec @(TxWits BabbageEra) v "transaction_witness_set"
+        huddleDecoderEquivalenceSpec @(Redeemers BabbageEra) v "redeemers"
+        huddleDecoderEquivalenceSpec @(Tx BabbageEra) v "transaction"

eras/conway/impl/test/Test/Cardano/Ledger/Conway/Binary/CddlSpec.hs

@@ -12,10 +12,12 @@ import Cardano.Ledger.Core
 import Cardano.Ledger.Plutus.Data (Data, Datum)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
 import Test.Cardano.Ledger.Binary.Cuddle (
+  huddleDecoderEquivalenceSpec,
   huddleRoundTripAnnCborSpec,
   huddleRoundTripCborSpec,
   specWithHuddle,
@@ -55,6 +57,15 @@ spec = do
       cddlRoundTripCborSpec @(ProposalProcedure ConwayEra) v "proposal_procedure"
       cddlRoundTripCborSpec @(GovAction ConwayEra) v "gov_action"
       cddlRoundTripCborSpec @(TxCert ConwayEra) v "certificate"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(TxBody ConwayEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(TxAuxData ConwayEra) v "auxiliary_data"
+        cddlDecoderEquivalenceSpec @(Timelock ConwayEra) v "native_script"
+        cddlDecoderEquivalenceSpec @(Data ConwayEra) v "plutus_data"
+        cddlDecoderEquivalenceSpec @(Script ConwayEra) v "script"
+        cddlDecoderEquivalenceSpec @(TxWits ConwayEra) v "transaction_witness_set"
+        cddlDecoderEquivalenceSpec @(Redeemers ConwayEra) v "redeemers"
+        cddlDecoderEquivalenceSpec @(Tx ConwayEra) v "transaction"
     describe "Huddle" $ specWithHuddle conwayCDDL 100 $ do
       huddleRoundTripCborSpec @(Value ConwayEra) v "positive_coin"
       huddleRoundTripCborSpec @(Value ConwayEra) v "value"
@@ -82,3 +93,12 @@ spec = do
       huddleRoundTripCborSpec @(ProposalProcedure ConwayEra) v "proposal_procedure"
       huddleRoundTripCborSpec @(GovAction ConwayEra) v "gov_action"
       huddleRoundTripCborSpec @(TxCert ConwayEra) v "certificate"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        huddleDecoderEquivalenceSpec @(TxBody ConwayEra) v "transaction_body"
+        huddleDecoderEquivalenceSpec @(TxAuxData ConwayEra) v "auxiliary_data"
+        huddleDecoderEquivalenceSpec @(Timelock ConwayEra) v "native_script"
+        huddleDecoderEquivalenceSpec @(Data ConwayEra) v "plutus_data"
+        huddleDecoderEquivalenceSpec @(Script ConwayEra) v "script"
+        huddleDecoderEquivalenceSpec @(TxWits ConwayEra) v "transaction_witness_set"
+        huddleDecoderEquivalenceSpec @(Redeemers ConwayEra) v "redeemers"
+        huddleDecoderEquivalenceSpec @(Tx ConwayEra) v "transaction"

eras/mary/impl/test/Test/Cardano/Ledger/Mary/Binary/CddlSpec.hs

@@ -7,6 +7,7 @@ import Cardano.Ledger.Core
 import Cardano.Ledger.Mary (MaryEra)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
@@ -27,6 +28,10 @@ spec =
       cddlRoundTripCborSpec @(Script MaryEra) v "native_script"
       cddlRoundTripAnnCborSpec @(TxAuxData MaryEra) v "auxiliary_data"
       cddlRoundTripCborSpec @(TxAuxData MaryEra) v "auxiliary_data"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(TxBody MaryEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(Script MaryEra) v "native_script"
+        cddlDecoderEquivalenceSpec @(TxAuxData MaryEra) v "auxiliary_data"
     describe "Huddle" $ specWithHuddle maryCDDL 100 $ do
       huddleRoundTripCborSpec @(Value MaryEra) v "value"
       huddleRoundTripAnnCborSpec @(TxBody MaryEra) v "transaction_body"
@@ -35,3 +40,7 @@ spec =
       huddleRoundTripCborSpec @(TxAuxData MaryEra) v "auxiliary_data"
       huddleRoundTripAnnCborSpec @(Script MaryEra) v "native_script"
       huddleRoundTripCborSpec @(Script MaryEra) v "native_script"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        huddleDecoderEquivalenceSpec @(TxBody MaryEra) v "transaction_body"
+        huddleDecoderEquivalenceSpec @(Script MaryEra) v "native_script"
+        huddleDecoderEquivalenceSpec @(TxAuxData MaryEra) v "auxiliary_data"

eras/shelley/impl/test/Test/Cardano/Ledger/Shelley/Binary/CddlSpec.hs

@@ -19,10 +19,12 @@ import Cardano.Ledger.Shelley.API (
 import Cardano.Ledger.TxIn (TxIn)
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
 import Test.Cardano.Ledger.Binary.Cuddle (
+  huddleDecoderEquivalenceSpec,
   huddleRoundTripAnnCborSpec,
   huddleRoundTripCborSpec,
   specWithHuddle,
@@ -56,6 +58,13 @@ spec =
       cddlRoundTripCborSpec @(PParamsUpdate ShelleyEra) v "protocol_param_update"
       cddlRoundTripAnnCborSpec @(Tx ShelleyEra) v "transaction"
       cddlRoundTripCborSpec @(Tx ShelleyEra) v "transaction"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @BootstrapWitness v "bootstrap_witness"
+        cddlDecoderEquivalenceSpec @(TxBody ShelleyEra) v "transaction_body"
+        cddlDecoderEquivalenceSpec @(TxAuxData ShelleyEra) v "transaction_metadata"
+        cddlDecoderEquivalenceSpec @(MultiSig ShelleyEra) v "multisig_script"
+        cddlDecoderEquivalenceSpec @(Tx ShelleyEra) v "transaction"
+
     describe "Huddle" $ specWithHuddle shelleyCDDL 100 $ do
       huddleRoundTripCborSpec @Addr v "address"
       huddleRoundTripAnnCborSpec @BootstrapWitness v "bootstrap_witness"
@@ -79,3 +88,9 @@ spec =
       huddleRoundTripCborSpec @(Tx ShelleyEra) v "transaction"
       huddleRoundTripAnnCborSpec @(TxWits ShelleyEra) v "transaction_witness_set"
       huddleRoundTripCborSpec @(TxWits ShelleyEra) v "transaction_witness_set"
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        huddleDecoderEquivalenceSpec @BootstrapWitness v "bootstrap_witness"
+        huddleDecoderEquivalenceSpec @(TxBody ShelleyEra) v "transaction_body"
+        huddleDecoderEquivalenceSpec @(TxAuxData ShelleyEra) v "transaction_metadata"
+        huddleDecoderEquivalenceSpec @(MultiSig ShelleyEra) v "multisig_script"
+        huddleDecoderEquivalenceSpec @(Tx ShelleyEra) v "transaction"

libs/cardano-protocol-tpraos/test/Test/Cardano/Protocol/Binary/CddlSpec.hs

@@ -14,11 +14,14 @@ import Cardano.Protocol.TPraos.OCert (OCert)
 import qualified Data.ByteString.Lazy as BSL
 import Test.Cardano.Ledger.Binary.Cddl (
   beforeAllCddlFile,
+  cddlDecoderEquivalenceSpec,
   cddlRoundTripAnnCborSpec,
   cddlRoundTripCborSpec,
  )
+import Test.Cardano.Ledger.Binary.Cuddle
 import Test.Cardano.Ledger.Common
 import Test.Cardano.Ledger.Shelley.Binary.Cddl (readShelleyCddlFiles)
+import Test.Cardano.Ledger.Shelley.CDDL (shelleyCDDL)
 
 spec :: Spec
 spec =
@@ -28,10 +31,16 @@ spec =
 
 specForEra :: forall era. Era era => IO [BSL.ByteString] -> Int -> Spec
 specForEra readCddlFiles n = do
-  describe (eraName @era) $
+  describe (eraName @era) $ do
+    let v = eraProtVerLow @era
     beforeAllCddlFile n readCddlFiles $ do
-      let v = eraProtVerLow @era
       cddlRoundTripAnnCborSpec @(BHeader StandardCrypto) v "header"
       cddlRoundTripCborSpec @(BHeader StandardCrypto) v "header"
       cddlRoundTripCborSpec @(BHBody StandardCrypto) v "header_body"
       cddlRoundTripCborSpec @(CBORGroup (OCert StandardCrypto)) v "[ operational_cert ]"
+      -- TODO: add Huddle round trip tests
+      describe "DecCBOR instances equivalence via CDDL" $ do
+        cddlDecoderEquivalenceSpec @(BHeader StandardCrypto) v "header"
+    describe "DecCBOR instances equivalence via CDDL - Huddle" $ do
+      specWithHuddle shelleyCDDL 100 $ do
+        huddleDecoderEquivalenceSpec @(BHeader StandardCrypto) v "header"