Add property tests for tx size computation in each era

Author: teodanciu

eras/allegra/impl/test/Test/Cardano/Ledger/Allegra/BinarySpec.hs

@@ -11,7 +11,7 @@ import Test.Cardano.Ledger.Allegra.Arbitrary ()
 import Test.Cardano.Ledger.Allegra.TreeDiff ()
 import Test.Cardano.Ledger.Common
 import Test.Cardano.Ledger.Core.Binary (specUpgrade)
-import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec)
+import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec, txSizeSpec)
 import Test.Cardano.Ledger.Core.Binary.RoundTrip (RuleListEra (..))
 import Test.Cardano.Ledger.Shelley.Binary.RoundTrip (roundTripShelleyCommonSpec)
 
@@ -22,6 +22,7 @@ spec = do
     roundTripShelleyCommonSpec @AllegraEra
   describe "DecCBOR instances equivalence" $ do
     Binary.decoderEquivalenceCoreEraTypesSpec @AllegraEra
+  Binary.txSizeSpec @AllegraEra
 
 instance RuleListEra AllegraEra where
   type

eras/alonzo/impl/test/Test/Cardano/Ledger/Alonzo/BinarySpec.hs

@@ -13,6 +13,7 @@ import Test.Cardano.Ledger.Core.Binary (BinaryUpgradeOpts (..), specUpgrade)
 import Test.Cardano.Ledger.Core.Binary as Binary (
   decoderEquivalenceCoreEraTypesSpec,
   decoderEquivalenceEraSpec,
+  txSizeSpec,
  )
 import Test.Cardano.Ledger.Core.Binary.RoundTrip (roundTripEraSpec)
 
@@ -31,3 +32,4 @@ spec = do
     Binary.decoderEquivalenceCoreEraTypesSpec @AlonzoEra
     decoderEquivalenceEraSpec @AlonzoEra @(TxDats AlonzoEra)
     decoderEquivalenceEraSpec @AlonzoEra @(Redeemers AlonzoEra)
+  Binary.txSizeSpec @AlonzoEra

eras/babbage/impl/test/Test/Cardano/Ledger/Babbage/BinarySpec.hs

@@ -16,6 +16,7 @@ import Test.Cardano.Ledger.Core.Binary (specUpgrade)
 import Test.Cardano.Ledger.Core.Binary as Binary (
   decoderEquivalenceCoreEraTypesSpec,
   decoderEquivalenceEraSpec,
+  txSizeSpec,
  )
 import Test.Cardano.Ledger.Core.Binary.RoundTrip (RuleListEra (..))
 
@@ -28,6 +29,7 @@ spec = do
     Binary.decoderEquivalenceCoreEraTypesSpec @BabbageEra
     decoderEquivalenceEraSpec @BabbageEra @(TxDats BabbageEra)
     decoderEquivalenceEraSpec @BabbageEra @(Redeemers BabbageEra)
+  Binary.txSizeSpec @BabbageEra
 
 instance RuleListEra BabbageEra where
   type

eras/conway/impl/test/Test/Cardano/Ledger/Conway/BinarySpec.hs

@@ -22,7 +22,7 @@ import Test.Cardano.Ledger.Conway.Arbitrary ()
 import Test.Cardano.Ledger.Conway.Binary.RoundTrip (roundTripConwayCommonSpec)
 import Test.Cardano.Ledger.Conway.TreeDiff ()
 import Test.Cardano.Ledger.Core.Binary (specUpgrade)
-import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec)
+import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec, txSizeSpec)
 import Test.Cardano.Ledger.Core.Binary.RoundTrip (roundTripEraSpec)
 
 spec :: Spec
@@ -43,6 +43,7 @@ spec = do
     Binary.decoderEquivalenceCoreEraTypesSpec @ConwayEra
     decoderEquivalenceLenientSpec @(TxDats ConwayEra)
     decoderEquivalenceLenientSpec @(Redeemers ConwayEra)
+  Binary.txSizeSpec @ConwayEra
   where
     -- The expectation used in this spec allows for the deserialization to fail, in which case
     -- it only checks that it fails for both decoders.

eras/mary/impl/test/Test/Cardano/Ledger/Mary/BinarySpec.hs

@@ -9,7 +9,7 @@ import Cardano.Ledger.Mary
 import Data.Default (def)
 import Test.Cardano.Ledger.Common
 import Test.Cardano.Ledger.Core.Binary (specUpgrade)
-import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec)
+import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec, txSizeSpec)
 import Test.Cardano.Ledger.Core.Binary.RoundTrip (RuleListEra (..))
 import Test.Cardano.Ledger.Mary.Arbitrary ()
 import Test.Cardano.Ledger.Mary.TreeDiff ()
@@ -22,6 +22,7 @@ spec = do
     roundTripShelleyCommonSpec @MaryEra
   describe "DecCBOR instances equivalence" $ do
     Binary.decoderEquivalenceCoreEraTypesSpec @MaryEra
+  Binary.txSizeSpec @MaryEra
 
 instance RuleListEra MaryEra where
   type

eras/shelley/impl/test/Test/Cardano/Ledger/Shelley/BinarySpec.hs

@@ -1,10 +1,11 @@
+{-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TypeApplications #-}
 
 module Test.Cardano.Ledger.Shelley.BinarySpec (spec) where
 
 import Cardano.Ledger.Shelley (ShelleyEra)
 import Test.Cardano.Ledger.Common
-import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec)
+import Test.Cardano.Ledger.Core.Binary as Binary (decoderEquivalenceCoreEraTypesSpec, txSizeSpec)
 import qualified Test.Cardano.Ledger.Shelley.Binary.GoldenSpec as Golden
 import qualified Test.Cardano.Ledger.Shelley.Binary.RoundTripSpec as RoundTrip
 
@@ -13,3 +14,4 @@ spec = do
   Golden.spec
   RoundTrip.spec
   Binary.decoderEquivalenceCoreEraTypesSpec @ShelleyEra
+  Binary.txSizeSpec @ShelleyEra

libs/cardano-ledger-core/cardano-ledger-core.cabal

@@ -206,6 +206,7 @@ library testlib
     hedgehog-quickcheck,
     heredoc,
     hspec,
+    microlens,
     mtl,
     nothunks,
     plutus-ledger-api:{plutus-ledger-api, plutus-ledger-api-testlib},

libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Binary.hs

@@ -11,13 +11,15 @@ module Test.Cardano.Ledger.Core.Binary (
   decoderEquivalenceCoreEraTypesSpec,
   specUpgrade,
   decoderEquivalenceEraSpec,
+  txSizeSpec,
 ) where
 
 import Cardano.Ledger.Binary (Annotator, DecCBOR, ToCBOR, decNoShareCBOR, encodeMemPack)
 import Cardano.Ledger.Core
 import Cardano.Ledger.MemoBytes (EqRaw (eqRaw))
 import Cardano.Ledger.Plutus (Data)
 import Data.Default (Default (def))
+import Lens.Micro
 import qualified Prettyprinter as Pretty
 import Test.Cardano.Ledger.Binary (decoderEquivalenceSpec)
 import Test.Cardano.Ledger.Binary.RoundTrip
@@ -325,3 +327,16 @@ decoderEquivalenceCoreEraTypesSpec =
     decoderEquivalenceEraSpec @era @(TxWits era)
     decoderEquivalenceEraSpec @era @(TxBody era)
     decoderEquivalenceEraSpec @era @(Tx era)
+
+txSizeSpec ::
+  forall era.
+  ( EraTx era
+  , Arbitrary (Tx era)
+  , SafeToHash (TxWits era)
+  ) =>
+  Spec
+txSizeSpec =
+  describe "Transaction size" $ do
+    prop "should match the size of the cbor encoding" $ \(tx :: Tx era) -> do
+      let txSize = sizeTxForFeeCalculation tx
+      txSize `shouldBe` tx ^. sizeTxF