Merge pull request #4993 from IntersectMBO/nm/3130-redundant-accessor-functions

Deprecate redundant accessor functions in Alonzo

Author: lehins

eras/alonzo/impl/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## 1.14.0.0
 
+* Deprecate `inputs'`, `collateral'`, `outputs'`, `certs'`, `withdrawals'`, `txfee'`,
+  `vldt'`, `update'`, `reqSignerHashes'`, `adHash'`, `mint'`, `scriptIntegrityHash'`,
+  and `txnetworkid'`
 * Move `Annotator` instances and `alonzoSegwitTx` to `testlib`
 * Expose `addScriptsTxWitsRaw`, `decodeAlonzoPlutusScript` and `asHashedScriptPair`
 * Expose `emptyAlonzoTxAuxDataRaw`, `decodeTxAuxDataByTokenType` and `addPlutusScripts`

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxBody/Internal.hs

@@ -500,30 +500,43 @@ mint' :: AlonzoTxBody era -> MultiAsset
 scriptIntegrityHash' :: AlonzoTxBody era -> StrictMaybe ScriptIntegrityHash
 txnetworkid' :: AlonzoTxBody era -> StrictMaybe Network
 inputs' = atbrInputs . getMemoRawType
+{-# DEPRECATED inputs' "In favor of inputsTxBodyL" #-}
 
 collateral' = atbrCollateral . getMemoRawType
+{-# DEPRECATED collateral' "In favor of collateralInputsTxBodyL" #-}
 
 outputs' = atbrOutputs . getMemoRawType
+{-# DEPRECATED outputs' "In favor of outputsTxBodyL" #-}
 
 certs' = atbrCerts . getMemoRawType
+{-# DEPRECATED certs' "In favor of certsTxBodyL" #-}
 
 withdrawals' = atbrWithdrawals . getMemoRawType
+{-# DEPRECATED withdrawals' "In favor of withdrawalsTxBodyL" #-}
 
 txfee' = atbrTxFee . getMemoRawType
+{-# DEPRECATED txfee' "In favor of feeTxBodyL" #-}
 
 vldt' = atbrValidityInterval . getMemoRawType
+{-# DEPRECATED vldt' "In favor of vldtTxBodyL" #-}
 
 update' = atbrUpdate . getMemoRawType
+{-# DEPRECATED update' "In favor of updateTxBodyL" #-}
 
 reqSignerHashes' = atbrReqSignerHashes . getMemoRawType
+{-# DEPRECATED reqSignerHashes' "In favor of reqSignerHashesTxBodyL" #-}
 
 adHash' = atbrAuxDataHash . getMemoRawType
+{-# DEPRECATED adHash' "In favor of auxDataHashTxBodyL" #-}
 
 mint' = atbrMint . getMemoRawType
+{-# DEPRECATED mint' "In favor of mintTxBodyL" #-}
 
 scriptIntegrityHash' = atbrScriptIntegrityHash . getMemoRawType
+{-# DEPRECATED scriptIntegrityHash' "In favor of scriptIntegrityHashTxBodyL" #-}
 
 txnetworkid' = atbrTxNetworkId . getMemoRawType
+{-# DEPRECATED txnetworkid' "In favor of networkIdTxBodyL" #-}
 
 instance
   (Era era, Eq (PParamsUpdate era), Eq (TxOut era), Eq (TxCert era)) =>

eras/alonzo/test-suite/src/Test/Cardano/Ledger/Alonzo/AlonzoEraGen.hs

@@ -47,7 +47,6 @@ import Cardano.Ledger.Alonzo.TxAuxData (AlonzoTxAuxData (..), mkAlonzoTxAuxData)
 import Cardano.Ledger.Alonzo.TxBody (
   AlonzoTxBody (..),
   AlonzoTxOut (..),
-  inputs',
   utxoEntrySize,
  )
 import Cardano.Ledger.Alonzo.TxWits (
@@ -429,7 +428,7 @@ instance EraGen AlonzoEra where
           (dataMapFromTxOut smallUtxo (TxDats (getDataMap scriptinfo mapScriptWit)))
           -- The data hashes come from two places
           (Redeemers rdmrMap)
-      txinputs = inputs' txbody
+      txinputs = txbody ^. inputsTxBodyL
       smallUtxo :: [TxOut AlonzoEra]
       smallUtxo = Map.elems (unUTxO (txInsFilter utxo txinputs))
       AlonzoScriptsNeeded purposeHashPairs = getScriptsNeeded @AlonzoEra utxo txbody