Add tests for --out-file option of the 'calculate-min-fee' command

Author: newhoggy

cardano-cli/test/Test/Golden/Shelley.hs

@@ -84,7 +84,8 @@ import           Test.Golden.Shelley.Transaction.Build (golden_shelleyTransactio
                    golden_shelleyTransactionBuild_TxInScriptWitnessed,
                    golden_shelleyTransactionBuild_WithdrawalScriptWitnessed)
 import           Test.Golden.Shelley.Transaction.CalculateMinFee
-                   (golden_shelleyTransactionCalculateMinFee)
+                   (golden_shelleyTransactionCalculateMinFee,
+                   golden_shelleyTransactionCalculateMinFee_outFile)
 import           Test.Golden.Shelley.Transaction.CreateWitness
                    (golden_shelleyTransactionSigningKeyWitness)
 import           Test.Golden.Shelley.Transaction.Sign (golden_shelleyTransactionSign)
@@ -132,6 +133,7 @@ keyTests =
         , ("golden_shelleyTransactionBuild_CertificateScriptWitnessed", golden_shelleyTransactionBuild_CertificateScriptWitnessed)
         , ("golden_shelleyTransactionBuild_WithdrawalScriptWitnessed", golden_shelleyTransactionBuild_WithdrawalScriptWitnessed)
         , ("golden_shelleyTransactionCalculateMinFee", golden_shelleyTransactionCalculateMinFee)
+        , ("golden_shelleyTransactionCalculateMinFee_outFile", golden_shelleyTransactionCalculateMinFee_outFile)
         , ("golden_shelleyTransactionSign", golden_shelleyTransactionSign)
         , ("golden_shelleyVRFKeys", golden_shelleyVRFKeys)
         , ("golden_version", golden_version)

cardano-cli/test/Test/Golden/Shelley/Transaction/CalculateMinFee.hs

@@ -2,13 +2,14 @@
 
 module Test.Golden.Shelley.Transaction.CalculateMinFee
   ( golden_shelleyTransactionCalculateMinFee
+  , golden_shelleyTransactionCalculateMinFee_outFile
   ) where
 
-import           Hedgehog (Property)
-import           Test.OptParse
-
+import           Hedgehog (Property, (===))
 import qualified Hedgehog.Extras.Test.Base as H
 import qualified Hedgehog.Extras.Test.File as H
+import           Test.OptParse
+import           Test.Utilities (diffVsGoldenFile)
 
 {- HLINT ignore "Use camelCase" -}
 
@@ -34,3 +35,27 @@ golden_shelleyTransactionCalculateMinFee = propertyOnce $ H.moduleWorkspace "tmp
   H.assertFileOccurences 1 "5083100" minFeeTxtFile
   H.assertFileLines (== 1) minFeeTxtFile
   H.assertEndsWithSingleNewline minFeeTxtFile
+
+golden_shelleyTransactionCalculateMinFee_outFile :: Property
+golden_shelleyTransactionCalculateMinFee_outFile = propertyOnce $ H.moduleWorkspace "tmp" $ \tempDir -> do
+  protocolParamsJsonFile <- noteInputFile "test/data/golden/shelley/transaction-calculate-min-fee/protocol-params.json"
+  txBodyFile <- noteInputFile "test/data/golden/shelley/tx/txbody"
+  outFile <- noteTempFile tempDir "out-file"
+
+  minFeeTxt <- execCardanoCLI
+    [ "transaction","calculate-min-fee"
+    , "--out-file", outFile
+    , "--tx-in-count", "32"
+    , "--tx-out-count", "27"
+    , "--byron-witness-count", "5"
+    , "--witness-count", "10"
+    , "--testnet-magic", "4036000900"
+    , "--protocol-params-file", protocolParamsJsonFile
+    , "--tx-body-file", txBodyFile
+    ]
+
+  minFeeTxt === ""
+
+  resultJson <- H.readFile outFile
+
+  diffVsGoldenFile resultJson "test/data/golden/shelley/tx/calculate-min-fee/out-file.json"

cardano-cli/test/Test/Utilities.hs

@@ -58,7 +58,7 @@ diffVsGoldenFile actualContent referenceFile = GHC.withFrozenCallStack $ do
         -- CREATE_GOLDEN_FILES is set, so we create any golden files that don't
         -- already exist.
         H.note_ $ "Creating golden file " <> referenceFile
-        H.createDirectoryIfMissing (takeDirectory referenceFile)
+        H.createDirectoryIfMissing_ (takeDirectory referenceFile)
         H.writeFile referenceFile actualContent
       else do
         H.note_ $ mconcat

cardano-cli/test/data/golden/shelley/tx/calculate-min-fee/out-file.json

@@ -0,0 +1 @@
+5083100